Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-10 15:14:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add run-rustfix for int_plus_one test

Browse source
This commit is contained in:
Philipp Hansch 2019-08-18 09:24:30 +02:00
parent cb341c8090
commit b6e87c6ae3
No known key found for this signature in database
GPG key ID: 82AA61CAA11397E6
3 changed files with 45 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/ui/int_plus_one.fixed Normal file
View file

@ -0,0 +1,17 @@
// run-rustfix
#[allow(clippy::no_effect, clippy::unnecessary_operation)]
#[warn(clippy::int_plus_one)]
fn main() {
let x = 1i32;
let y = 0i32;
let _ = x > y;
let _ = y < x;
let _ = x > y;
let _ = y < x;
let _ = x > y; // should be ok
let _ = y < x; // should be ok
}

14
tests/ui/int_plus_one.rs
View file

@ -1,15 +1,17 @@
// run-rustfix
#[allow(clippy::no_effect, clippy::unnecessary_operation)]
#[warn(clippy::int_plus_one)]
fn main() {
let x = 1i32;
let y = 0i32;
x >= y + 1;
y + 1 <= x;
let _ = x >= y + 1;
let _ = y + 1 <= x;
x - 1 >= y;
y <= x - 1;
let _ = x - 1 >= y;
let _ = y <= x - 1;
x > y; // should be ok
y < x; // should be ok
let _ = x > y; // should be ok
let _ = y < x; // should be ok
}

40
tests/ui/int_plus_one.stderr
View file

@ -1,44 +1,44 @@
error: Unnecessary `>= y + 1` or `x - 1 >=`
--> $DIR/int_plus_one.rs:7:5
--> $DIR/int_plus_one.rs:9:13
|
LL | x >= y + 1;
| ^^^^^^^^^^
LL | let _ = x >= y + 1;
| ^^^^^^^^^^
|
= note: `-D clippy::int-plus-one` implied by `-D warnings`
help: change `>= y + 1` to `> y` as shown
|
LL | x > y;
| ^^^^^
LL | let _ = x > y;
| ^^^^^
error: Unnecessary `>= y + 1` or `x - 1 >=`
--> $DIR/int_plus_one.rs:8:5
--> $DIR/int_plus_one.rs:10:13
|
LL | y + 1 <= x;
| ^^^^^^^^^^
LL | let _ = y + 1 <= x;
| ^^^^^^^^^^
help: change `>= y + 1` to `> y` as shown
|
LL | y < x;
| ^^^^^
LL | let _ = y < x;
| ^^^^^
error: Unnecessary `>= y + 1` or `x - 1 >=`
--> $DIR/int_plus_one.rs:10:5
--> $DIR/int_plus_one.rs:12:13
|
LL | x - 1 >= y;
| ^^^^^^^^^^
LL | let _ = x - 1 >= y;
| ^^^^^^^^^^
help: change `>= y + 1` to `> y` as shown
|
LL | x > y;
| ^^^^^
LL | let _ = x > y;
| ^^^^^
error: Unnecessary `>= y + 1` or `x - 1 >=`
--> $DIR/int_plus_one.rs:11:5
--> $DIR/int_plus_one.rs:13:13
|
LL | y <= x - 1;
| ^^^^^^^^^^
LL | let _ = y <= x - 1;
| ^^^^^^^^^^
help: change `>= y + 1` to `> y` as shown
|
LL | y < x;
| ^^^^^
LL | let _ = y < x;
| ^^^^^
error: aborting due to 4 previous errors