Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 23:20:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

inconsistent_struct_constructor: Check HIR tree first.

Browse source
This commit is contained in:
Jason Newcomb 2024-06-11 15:06:14 -04:00
parent 3869e93408
commit b58b491d16
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/inconsistent_struct_constructor.rs
View file

@ -65,13 +65,13 @@ declare_lint_pass!(InconsistentStructConstructor => [INCONSISTENT_STRUCT_CONSTRU
impl<'tcx> LateLintPass<'tcx> for InconsistentStructConstructor { impl<'tcx> LateLintPass<'tcx> for InconsistentStructConstructor {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>) { fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>) {
if !expr.span.from_expansion() if let ExprKind::Struct(qpath, fields, base) = expr.kind
&& let ExprKind::Struct(qpath, fields, base) = expr.kind && fields.iter().all(|f| f.is_shorthand)
&& !expr.span.from_expansion()
&& let ty = cx.typeck_results().expr_ty(expr) && let ty = cx.typeck_results().expr_ty(expr)
&& let Some(adt_def) = ty.ty_adt_def() && let Some(adt_def) = ty.ty_adt_def()
&& adt_def.is_struct() && adt_def.is_struct()
&& let Some(variant) = adt_def.variants().iter().next() && let Some(variant) = adt_def.variants().iter().next()
&& fields.iter().all(|f| f.is_shorthand)
{ {
let mut def_order_map = FxHashMap::default(); let mut def_order_map = FxHashMap::default();
for (idx, field) in variant.fields.iter().enumerate() { for (idx, field) in variant.fields.iter().enumerate() {