Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Reduce false positives

Browse source 
Add macro checking, and only lint for single leading underscores
This commit is contained in:
Devon Hollowood 2015-12-12 17:51:58 -08:00
parent 6091112698
commit aeb5a0e60c
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/misc.rs
View file

@ -334,19 +334,24 @@ impl LateLintPass for UsedUnderscoreBinding {
fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
let needs_lint = match expr.node {
ExprPath(_, ref path) => {
path.segments.last().unwrap().identifier.name.as_str().chars().next() == Some('_') &&
(cx.tcx.def_map.borrow()).values().any(|res| match res.base_def {
let ident = path.segments.last()
.expect("path should always have at least one segment")
.identifier;
ident.name.as_str().chars().next() == Some('_') //starts with '_'
&& ident.name.as_str().chars().skip(1).next() != Some('_') //doesn't start with "__"
&& ident.name != ident.unhygienic_name //not in macro
&& cx.tcx.def_map.borrow().values().any(|res| match res.base_def {
Def::DefLocal(_, _) => true,
_ => false
})
}) //local variable
},
ExprField(_, spanned) => spanned.node.as_str().chars().next() == Some('_'),
_ => false
};
if needs_lint {
cx.span_lint(USED_UNDERSCORE_BINDING, expr.span, &format!(
"used binding which is prefixed with an underscore. A leading underscore signals\
that a binding will not be used."));
cx.span_lint(USED_UNDERSCORE_BINDING, expr.span,
"used binding which is prefixed with an underscore. A leading underscore\
signals that a binding will not be used.");
}
}
}