Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-28 15:41:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #280 from Manishearth/fx-279

Browse source 
Only handle ranges starting with 0 for needless_range_loop (fixes #279)
This commit is contained in:
llogiq 2015-09-02 12:44:21 +02:00
commit a9869e6fe4
2 changed files with 30 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/loops.rs
View file

@ -37,7 +37,11 @@ impl LintPass for LoopsPass {
if let Some((pat, arg, body)) = recover_for_loop(expr) { if let Some((pat, arg, body)) = recover_for_loop(expr) {
// check for looping over a range and then indexing a sequence with it // check for looping over a range and then indexing a sequence with it
// -> the iteratee must be a range literal // -> the iteratee must be a range literal
if let ExprRange(_, _) = arg.node { if let ExprRange(Some(ref l), _) = arg.node {
// Range should start with `0`
if let ExprLit(ref lit) = l.node {
if let LitInt(0, _) = lit.node {
// the var must be a single name // the var must be a single name
if let PatIdent(_, ref ident, _) = pat.node { if let PatIdent(_, ref ident, _) = pat.node {
let mut visitor = VarVisitor { cx: cx, var: ident.node.name, let mut visitor = VarVisitor { cx: cx, var: ident.node.name,
@ -61,6 +65,8 @@ impl LintPass for LoopsPass {
} }
} }
} }
}
}
if let ExprMethodCall(ref method, _, ref args) = arg.node { if let ExprMethodCall(ref method, _, ref args) = arg.node {
// just the receiver, no arguments // just the receiver, no arguments

4
tests/compile-fail/for_loop.rs
View file

@ -30,6 +30,10 @@ fn main() {
println!("{} {}", vec[i], vec2[i]); println!("{} {}", vec[i], vec2[i]);
} }
for i in 5..vec.len() { // not an error, not starting with 0
println!("{}", vec[i]);
}
for _v in vec.iter() { } //~ERROR it is more idiomatic to loop over `&vec` for _v in vec.iter() { } //~ERROR it is more idiomatic to loop over `&vec`
for _v in vec.iter_mut() { } //~ERROR it is more idiomatic to loop over `&mut vec` for _v in vec.iter_mut() { } //~ERROR it is more idiomatic to loop over `&mut vec`