Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-30 16:39:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Put tests for step_by(0) back.

Browse source
This commit is contained in:
uHOOCCOOHu 2017-07-05 14:51:33 +08:00
parent 85384afca3
commit a80db63515
No known key found for this signature in database
GPG key ID: 395939F0A802FC4B
2 changed files with 46 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
clippy_tests/examples/range.rs
View file

@ -10,9 +10,16 @@ impl NotARange {
#[warn(iterator_step_by_zero, range_zip_with_len)]
fn main() {
let _ = (0..1).step_by(0);
// No warning for non-zero step
let _ = (0..1).step_by(1);
let _ = (1..).step_by(0);
let _ = (1...2).step_by(0);
let x = 0..1;
let _ = x.step_by(0);
// No error, not a range.
let y = NotARange;
y.step_by(0);
@ -21,4 +28,7 @@ fn main() {
let v2 = vec![4,5];
let _x = v1.iter().zip(0..v1.len());
let _y = v1.iter().zip(0..v2.len()); // No error
// check const eval
let _ = v1.iter().step_by(2/3);
}

40
clippy_tests/examples/range.stderr
View file

@ -1,12 +1,44 @@
error: It is more idiomatic to use v1.iter().enumerate()
--> range.rs:22:14
error: Iterator::step_by(0) will panic at runtime
--> range.rs:13:13
|
22 | let _x = v1.iter().zip(0..v1.len());
13 | let _ = (0..1).step_by(0);
| ^^^^^^^^^^^^^^^^^
|
= note: `-D iterator-step-by-zero` implied by `-D warnings`
error: Iterator::step_by(0) will panic at runtime
--> range.rs:17:13
|
17 | let _ = (1..).step_by(0);
| ^^^^^^^^^^^^^^^^
error: Iterator::step_by(0) will panic at runtime
--> range.rs:18:13
|
18 | let _ = (1...2).step_by(0);
| ^^^^^^^^^^^^^^^^^^
error: Iterator::step_by(0) will panic at runtime
--> range.rs:21:13
|
21 | let _ = x.step_by(0);
| ^^^^^^^^^^^^
error: It is more idiomatic to use v1.iter().enumerate()
--> range.rs:29:14
|
29 | let _x = v1.iter().zip(0..v1.len());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D range-zip-with-len` implied by `-D warnings`
error: aborting due to previous error
error: Iterator::step_by(0) will panic at runtime
--> range.rs:33:13
|
33 | let _ = v1.iter().step_by(2/3);
| ^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 6 previous errors
To learn more, run the command again with --verbose.