Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 13:13:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix warnings of compiler_lint_functions

Browse source
This commit is contained in:
flip1995 2018-09-14 12:38:57 +02:00
parent aaeeaa5330
commit a4e1a90705
No known key found for this signature in database
GPG key ID: 9F184E1164831181
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
clippy_lints/src/double_parens.rs
View file

@ -1,6 +1,7 @@
use crate::syntax::ast::*; use crate::syntax::ast::*;
use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass}; use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
use crate::rustc::{declare_tool_lint, lint_array}; use crate::rustc::{declare_tool_lint, lint_array};
use crate::utils::span_lint;
/// **What it does:** Checks for unnecessary double parentheses. /// **What it does:** Checks for unnecessary double parentheses.
/// ///
@ -35,20 +36,20 @@ impl EarlyLintPass for DoubleParens {
match expr.node { match expr.node {
ExprKind::Paren(ref in_paren) => match in_paren.node { ExprKind::Paren(ref in_paren) => match in_paren.node {
ExprKind::Paren(_) | ExprKind::Tup(_) => { ExprKind::Paren(_) | ExprKind::Tup(_) => {
cx.span_lint(DOUBLE_PARENS, expr.span, "Consider removing unnecessary double parentheses"); span_lint(cx, DOUBLE_PARENS, expr.span, "Consider removing unnecessary double parentheses");
}, },
_ => {}, _ => {},
}, },
ExprKind::Call(_, ref params) => if params.len() == 1 { ExprKind::Call(_, ref params) => if params.len() == 1 {
let param = &params[0]; let param = &params[0];
if let ExprKind::Paren(_) = param.node { if let ExprKind::Paren(_) = param.node {
cx.span_lint(DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses"); span_lint(cx, DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
} }
}, },
ExprKind::MethodCall(_, ref params) => if params.len() == 2 { ExprKind::MethodCall(_, ref params) => if params.len() == 2 {
let param = &params[1]; let param = &params[1];
if let ExprKind::Paren(_) = param.node { if let ExprKind::Paren(_) = param.node {
cx.span_lint(DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses"); span_lint(cx, DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
} }
}, },
_ => {}, _ => {},