Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2025-02-17 14:38:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix ICE in implicit_return

Browse source 
async functions always return a value
This commit is contained in:
Jason Newcomb 2021-05-18 10:51:59 -04:00
parent 98cddc5d3a
commit a149ba26fa
No known key found for this signature in database
GPG key ID: DA59E8643A37ED06
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/implicit_return.rs
View file

@ -147,7 +147,11 @@ fn lint_implicit_returns(
visit_break_exprs(block, |break_expr, dest, sub_expr| {
if dest.target_id.ok() == Some(expr.hir_id) {
if call_site_span.is_none() && break_expr.span.ctxt() == ctxt {
lint_break(cx, break_expr.span, sub_expr.unwrap().span);
// At this point sub_expr can be `None` in async functions which either diverge, or return the
// unit type.
if let Some(sub_expr) = sub_expr {
lint_break(cx, break_expr.span, sub_expr.span);
}
} else {
// the break expression is from a macro call, add a return to the loop
add_return = true;

10
tests/ui/crashes/ice-7231.rs Normal file
View file

@ -0,0 +1,10 @@
// edition:2018
#![allow(clippy::never_loop)]
async fn f() {
loop {
break;
}
}
fn main() {}