From 96cba36b46ae1ab24da8de0d75e35328f23f7ebb Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Mon, 22 Jan 2018 10:35:01 +0530 Subject: [PATCH] Rustup to rustc 1.25.0-nightly (97520ccb1 2018-01-21) --- CHANGELOG.md | 11 ++++++++++- Cargo.toml | 4 ++-- clippy_lints/Cargo.toml | 2 +- clippy_lints/src/lib.rs | 9 +++------ 4 files changed, 16 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7af39eda8..c202f256e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ # Change Log All notable changes to this project will be documented in this file. +## 0.0.181 +* Rustup to *rustc 1.25.0-nightly (97520ccb1 2018-01-21)* +* New lints: [`else_if_without_else`], [`option_option`], [`unit_arg`], [`unnecessary_fold`] +* Removed [`unit_expr`] +* Various false positive fixes for [`needless_pass_by_value`] + ## 0.0.180 * Rustup to *rustc 1.25.0-nightly (3f92e8d89 2018-01-14)* @@ -544,6 +550,7 @@ All notable changes to this project will be documented in this file. [`drop_copy`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#drop_copy [`drop_ref`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#drop_ref [`duplicate_underscore_argument`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#duplicate_underscore_argument +[`else_if_without_else`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#else_if_without_else [`empty_enum`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#empty_enum [`empty_loop`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#empty_loop [`enum_clike_unportable_variant`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant @@ -653,6 +660,7 @@ All notable changes to this project will be documented in this file. [`option_map_or_none`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#option_map_or_none [`option_map_unwrap_or`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#option_map_unwrap_or [`option_map_unwrap_or_else`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#option_map_unwrap_or_else +[`option_option`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#option_option [`option_unwrap_used`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#option_unwrap_used [`or_fun_call`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#or_fun_call [`out_of_bounds_indexing`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#out_of_bounds_indexing @@ -711,9 +719,10 @@ All notable changes to this project will be documented in this file. [`trivial_regex`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#trivial_regex [`type_complexity`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#type_complexity [`unicode_not_nfc`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unicode_not_nfc +[`unit_arg`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unit_arg [`unit_cmp`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unit_cmp -[`unit_expr`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unit_expr [`unnecessary_cast`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unnecessary_cast +[`unnecessary_fold`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unnecessary_fold [`unnecessary_mut_passed`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [`unnecessary_operation`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unnecessary_operation [`unneeded_field_pattern`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unneeded_field_pattern diff --git a/Cargo.toml b/Cargo.toml index 040cb78d1..23147c6e7 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "clippy" -version = "0.0.180" +version = "0.0.181" authors = [ "Manish Goregaokar ", "Andre Bogus ", @@ -37,7 +37,7 @@ path = "src/driver.rs" [dependencies] # begin automatic update -clippy_lints = { version = "0.0.180", path = "clippy_lints" } +clippy_lints = { version = "0.0.181", path = "clippy_lints" } # end automatic update cargo_metadata = "0.2" regex = "0.2" diff --git a/clippy_lints/Cargo.toml b/clippy_lints/Cargo.toml index 87d7c7aee..380fc1369 100644 --- a/clippy_lints/Cargo.toml +++ b/clippy_lints/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "clippy_lints" # begin automatic update -version = "0.0.180" +version = "0.0.181" # end automatic update authors = [ "Manish Goregaokar ", diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index ee5974535..3a870fe71 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -248,10 +248,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) { "string_to_string", "using `string::to_string` is common even today and specialization will likely happen soon", ); - store.register_removed( - "unit_expr", - "superseded by `let_unit_value` and `unit_arg`", - ); // end deprecated lints, do not remove this comment, it’s used in `update_lints` reg.register_late_lint_pass(box serde_api::Serde); @@ -377,6 +373,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) { array_indexing::INDEXING_SLICING, assign_ops::ASSIGN_OPS, else_if_without_else::ELSE_IF_WITHOUT_ELSE, + methods::CLONE_ON_REF_PTR, misc::FLOAT_CMP_CONST, ]); @@ -520,7 +517,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) { methods::CHARS_NEXT_CMP, methods::CLONE_DOUBLE_REF, methods::CLONE_ON_COPY, - methods::CLONE_ON_REF_PTR, methods::FILTER_NEXT, methods::GET_UNWRAP, methods::ITER_CLONED_COLLECT, @@ -535,6 +531,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) { methods::SINGLE_CHAR_PATTERN, methods::STRING_EXTEND_CHARS, methods::TEMPORARY_CSTRING_AS_PTR, + methods::UNNECESSARY_FOLD, methods::USELESS_ASREF, methods::WRONG_SELF_CONVENTION, minmax::MIN_MAX, @@ -612,8 +609,8 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) { types::LINKEDLIST, types::OPTION_OPTION, types::TYPE_COMPLEXITY, - types::UNIT_CMP, types::UNIT_ARG, + types::UNIT_CMP, types::UNNECESSARY_CAST, unicode::ZERO_WIDTH_SPACE, unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,