Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 13:43:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

needless_late_init refactoring

Browse source 
Remove duplication in creating suggestions by first mapping assignments
to spans and then suggestions.
This commit is contained in:
Michael Wright 2022-06-05 07:14:31 +02:00
parent 542d474d38
commit 94e321a6ff
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
clippy_lints/src/needless_late_init.rs
View file

@ -185,13 +185,13 @@ fn assignment_suggestions<'tcx>(
let suggestions = assignments let suggestions = assignments
.iter() .iter()
.map(|assignment| Some((assignment.span.until(assignment.rhs_span), String::new()))) .map(|assignment| assignment.span.until(assignment.rhs_span))
.chain(assignments.iter().map(|assignment| { .chain(
Some(( assignments
assignment.rhs_span.shrink_to_hi().with_hi(assignment.span.hi()), .iter()
String::new(), .map(|assignment| assignment.rhs_span.shrink_to_hi().with_hi(assignment.span.hi())),
)) )
})) .map(|span| Some((span, String::new())))
.collect::<Option<Vec<(Span, String)>>>()?; .collect::<Option<Vec<(Span, String)>>>()?;
match suggestions.len() { match suggestions.len() {