Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-14 17:07:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #10730 - blyxyas:no_std_mul_add, r=Jarcho

Browse source 
`imprecise_flops`: Globally ignore `#[no_std]` crates

Really small fix.
Fixes #10728
changelog: [`imprecise_flops`]: Fix false positives with `#[no_std]`
This commit is contained in:
bors 2023-05-03 01:47:52 +00:00
commit 9353170dfb
1 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/floating_point_arithmetic.rs
View file

@ -453,9 +453,6 @@ fn is_float_mul_expr<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<(&'
// TODO: Fix rust-lang/rust-clippy#4735 // TODO: Fix rust-lang/rust-clippy#4735
fn check_mul_add(cx: &LateContext<'_>, expr: &Expr<'_>) { fn check_mul_add(cx: &LateContext<'_>, expr: &Expr<'_>) {
if is_no_std_crate(cx) {
return; // The suggested methods are not available in core
}
if let ExprKind::Binary( if let ExprKind::Binary(
Spanned { Spanned {
node: op @ (BinOpKind::Add | BinOpKind::Sub), node: op @ (BinOpKind::Add | BinOpKind::Sub),
@ -570,9 +567,6 @@ fn are_negated<'a>(cx: &LateContext<'_>, expr1: &'a Expr<'a>, expr2: &'a Expr<'a
} }
fn check_custom_abs(cx: &LateContext<'_>, expr: &Expr<'_>) { fn check_custom_abs(cx: &LateContext<'_>, expr: &Expr<'_>) {
if is_no_std_crate(cx) {
return; // The suggested methods are not available in core
}
if_chain! { if_chain! {
if let Some(higher::If { cond, then, r#else: Some(r#else) }) = higher::If::hir(expr); if let Some(higher::If { cond, then, r#else: Some(r#else) }) = higher::If::hir(expr);
let if_body_expr = peel_blocks(then); let if_body_expr = peel_blocks(then);
@ -737,7 +731,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {
impl<'tcx> LateLintPass<'tcx> for FloatingPointArithmetic { impl<'tcx> LateLintPass<'tcx> for FloatingPointArithmetic {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) { fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
// All of these operations are currently not const. // All of these operations are currently not const and are in std.
if in_constant(cx, expr.hir_id) { if in_constant(cx, expr.hir_id) {
return; return;
} }
@ -745,7 +739,7 @@ impl<'tcx> LateLintPass<'tcx> for FloatingPointArithmetic {
if let ExprKind::MethodCall(path, receiver, args, _) = &expr.kind { if let ExprKind::MethodCall(path, receiver, args, _) = &expr.kind {
let recv_ty = cx.typeck_results().expr_ty(receiver); let recv_ty = cx.typeck_results().expr_ty(receiver);
if recv_ty.is_floating_point() { if recv_ty.is_floating_point() && !is_no_std_crate(cx) {
match path.ident.name.as_str() { match path.ident.name.as_str() {
"ln" => check_ln1p(cx, expr, receiver), "ln" => check_ln1p(cx, expr, receiver),
"log" => check_log_base(cx, expr, receiver, args), "log" => check_log_base(cx, expr, receiver, args),
@ -756,10 +750,12 @@ impl<'tcx> LateLintPass<'tcx> for FloatingPointArithmetic {
} }
} }
} else { } else {
if !is_no_std_crate(cx) {
check_expm1(cx, expr); check_expm1(cx, expr);
check_mul_add(cx, expr); check_mul_add(cx, expr);
check_custom_abs(cx, expr); check_custom_abs(cx, expr);
check_log_division(cx, expr); check_log_division(cx, expr);
}
check_radians(cx, expr); check_radians(cx, expr);
} }
} }