Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-09-21 07:01:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rollup merge of #113657 - Urgau:expand-incorrect_fn_null_check-lint, r=cjgillot

Browse source 
Expand, rename and improve `incorrect_fn_null_checks` lint

This PR,

 - firstly, expand the lint by now linting on references
 - secondly, it renames the lint `incorrect_fn_null_checks` -> `useless_ptr_null_checks`
 - and thirdly it improves the lint by catching `ptr::from_mut`, `ptr::from_ref`, as well as `<*mut _>::cast` and `<*const _>::cast_mut`

Fixes https://github.com/rust-lang/rust/issues/113601
cc ```@est31```
This commit is contained in:
Matthias Krüger 2023-08-03 17:29:06 +02:00 committed by GitHub
commit 8f4f476a54
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/renamed_lints.rs
View file

@ -43,7 +43,7 @@ pub static RENAMED_LINTS: &[(&str, &str)] = &[
("clippy::for_loops_over_fallibles", "for_loops_over_fallibles"), ("clippy::for_loops_over_fallibles", "for_loops_over_fallibles"),
("clippy::forget_copy", "forgetting_copy_types"), ("clippy::forget_copy", "forgetting_copy_types"),
("clippy::forget_ref", "forgetting_references"), ("clippy::forget_ref", "forgetting_references"),
("clippy::fn_null_check", "incorrect_fn_null_checks"), ("clippy::fn_null_check", "useless_ptr_null_checks"),
("clippy::into_iter_on_array", "array_into_iter"), ("clippy::into_iter_on_array", "array_into_iter"),
("clippy::invalid_atomic_ordering", "invalid_atomic_ordering"), ("clippy::invalid_atomic_ordering", "invalid_atomic_ordering"),
("clippy::invalid_ref", "invalid_value"), ("clippy::invalid_ref", "invalid_value"),

4
tests/ui/rename.fixed
View file

@ -38,7 +38,7 @@
#![allow(for_loops_over_fallibles)] #![allow(for_loops_over_fallibles)]
#![allow(forgetting_copy_types)] #![allow(forgetting_copy_types)]
#![allow(forgetting_references)] #![allow(forgetting_references)]
#![allow(incorrect_fn_null_checks)] #![allow(useless_ptr_null_checks)]
#![allow(array_into_iter)] #![allow(array_into_iter)]
#![allow(invalid_atomic_ordering)] #![allow(invalid_atomic_ordering)]
#![allow(invalid_value)] #![allow(invalid_value)]
@ -92,7 +92,7 @@
#![warn(for_loops_over_fallibles)] #![warn(for_loops_over_fallibles)]
#![warn(forgetting_copy_types)] #![warn(forgetting_copy_types)]
#![warn(forgetting_references)] #![warn(forgetting_references)]
#![warn(incorrect_fn_null_checks)] #![warn(useless_ptr_null_checks)]
#![warn(array_into_iter)] #![warn(array_into_iter)]
#![warn(invalid_atomic_ordering)] #![warn(invalid_atomic_ordering)]
#![warn(invalid_value)] #![warn(invalid_value)]

2
tests/ui/rename.rs
View file

@ -38,7 +38,7 @@
#![allow(for_loops_over_fallibles)] #![allow(for_loops_over_fallibles)]
#![allow(forgetting_copy_types)] #![allow(forgetting_copy_types)]
#![allow(forgetting_references)] #![allow(forgetting_references)]
#![allow(incorrect_fn_null_checks)] #![allow(useless_ptr_null_checks)]
#![allow(array_into_iter)] #![allow(array_into_iter)]
#![allow(invalid_atomic_ordering)] #![allow(invalid_atomic_ordering)]
#![allow(invalid_value)] #![allow(invalid_value)]

4
tests/ui/rename.stderr
View file

@ -246,11 +246,11 @@ error: lint `clippy::forget_ref` has been renamed to `forgetting_references`
LL | #![warn(clippy::forget_ref)] LL | #![warn(clippy::forget_ref)]
| ^^^^^^^^^^^^^^^^^^ help: use the new name: `forgetting_references` | ^^^^^^^^^^^^^^^^^^ help: use the new name: `forgetting_references`
error: lint `clippy::fn_null_check` has been renamed to `incorrect_fn_null_checks` error: lint `clippy::fn_null_check` has been renamed to `useless_ptr_null_checks`
--> $DIR/rename.rs:95:9 --> $DIR/rename.rs:95:9
| |
LL | #![warn(clippy::fn_null_check)] LL | #![warn(clippy::fn_null_check)]
| ^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `incorrect_fn_null_checks` | ^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `useless_ptr_null_checks`
error: lint `clippy::into_iter_on_array` has been renamed to `array_into_iter` error: lint `clippy::into_iter_on_array` has been renamed to `array_into_iter`
--> $DIR/rename.rs:96:9 --> $DIR/rename.rs:96:9