Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-28 15:41:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #8552 - Jarcho:ptr_arg_8495, r=xFrednet

Browse source 
Don't lint `ptr_arg` on `&mut Cow<_>`

fixes: #8495

changelog: Don't lint `ptr_arg` on `&mut Cow<_>`
This commit is contained in:
bors 2022-03-17 17:05:26 +00:00
commit 8d5c0eadde
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/ptr.rs
View file

@ -436,7 +436,7 @@ fn check_fn_args<'cx, 'tcx: 'cx>(
DerefTy::Path, DerefTy::Path,
None, None,
), ),
Some(sym::Cow) => { Some(sym::Cow) if mutability == Mutability::Not => {
let ty_name = name.args let ty_name = name.args
.and_then(|args| { .and_then(|args| {
args.args.iter().find_map(|a| match a { args.args.iter().find_map(|a| match a {

7
tests/ui/ptr_arg.rs
View file

@ -194,3 +194,10 @@ fn two_vecs(a: &mut Vec<u32>, b: &mut Vec<u32>) {
a.push(0); a.push(0);
b.push(1); b.push(1);
} }
// Issue #8495
fn cow_conditional_to_mut(a: &mut Cow<str>) {
if a.is_empty() {
a.to_mut().push_str("foo");
}
}