chore: update some tests to allow const_is_empty

This commit is contained in:
Samuel Tardieu 2024-02-18 15:39:34 +01:00
parent dbfbd0e77f
commit 89b334d47c
11 changed files with 46 additions and 30 deletions

View file

@ -1,4 +1,4 @@
#![allow(unused, clippy::assertions_on_constants)]
#![allow(unused, clippy::assertions_on_constants, clippy::const_is_empty)]
#![warn(clippy::bool_assert_comparison)]
use std::ops::Not;

View file

@ -1,4 +1,4 @@
#![allow(unused, clippy::assertions_on_constants)]
#![allow(unused, clippy::assertions_on_constants, clippy::const_is_empty)]
#![warn(clippy::bool_assert_comparison)]
use std::ops::Not;

View file

@ -1,5 +1,11 @@
#![warn(clippy::len_zero)]
#![allow(dead_code, unused, clippy::needless_if, clippy::len_without_is_empty)]
#![allow(
dead_code,
unused,
clippy::needless_if,
clippy::len_without_is_empty,
clippy::const_is_empty
)]
extern crate core;
use core::ops::Deref;

View file

@ -1,5 +1,11 @@
#![warn(clippy::len_zero)]
#![allow(dead_code, unused, clippy::needless_if, clippy::len_without_is_empty)]
#![allow(
dead_code,
unused,
clippy::needless_if,
clippy::len_without_is_empty,
clippy::const_is_empty
)]
extern crate core;
use core::ops::Deref;

View file

@ -1,5 +1,5 @@
error: length comparison to zero
--> tests/ui/len_zero.rs:82:8
--> tests/ui/len_zero.rs:88:8
|
LL | if x.len() == 0 {
| ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()`
@ -8,13 +8,13 @@ LL | if x.len() == 0 {
= help: to override `-D warnings` add `#[allow(clippy::len_zero)]`
error: length comparison to zero
--> tests/ui/len_zero.rs:86:8
--> tests/ui/len_zero.rs:92:8
|
LL | if "".len() == 0 {}
| ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `"".is_empty()`
error: comparison to empty slice
--> tests/ui/len_zero.rs:95:20
--> tests/ui/len_zero.rs:101:20
|
LL | println!("{}", *s1 == "");
| ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s1.is_empty()`
@ -23,121 +23,121 @@ LL | println!("{}", *s1 == "");
= help: to override `-D warnings` add `#[allow(clippy::comparison_to_empty)]`
error: comparison to empty slice
--> tests/ui/len_zero.rs:96:20
--> tests/ui/len_zero.rs:102:20
|
LL | println!("{}", **s2 == "");
| ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s2.is_empty()`
error: comparison to empty slice
--> tests/ui/len_zero.rs:97:20
--> tests/ui/len_zero.rs:103:20
|
LL | println!("{}", ***s3 == "");
| ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s3.is_empty()`
error: comparison to empty slice
--> tests/ui/len_zero.rs:98:20
--> tests/ui/len_zero.rs:104:20
|
LL | println!("{}", ****s4 == "");
| ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s4.is_empty()`
error: comparison to empty slice
--> tests/ui/len_zero.rs:99:20
--> tests/ui/len_zero.rs:105:20
|
LL | println!("{}", *****s5 == "");
| ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s5.is_empty()`
error: comparison to empty slice
--> tests/ui/len_zero.rs:100:20
--> tests/ui/len_zero.rs:106:20
|
LL | println!("{}", ******(s6) == "");
| ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(s6).is_empty()`
error: comparison to empty slice
--> tests/ui/len_zero.rs:103:20
--> tests/ui/len_zero.rs:109:20
|
LL | println!("{}", &**d2s == "");
| ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(**d2s).is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:118:8
--> tests/ui/len_zero.rs:124:8
|
LL | if has_is_empty.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:121:8
--> tests/ui/len_zero.rs:127:8
|
LL | if has_is_empty.len() != 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:124:8
--> tests/ui/len_zero.rs:130:8
|
LL | if has_is_empty.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to one
--> tests/ui/len_zero.rs:127:8
--> tests/ui/len_zero.rs:133:8
|
LL | if has_is_empty.len() < 1 {
| ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `has_is_empty.is_empty()`
error: length comparison to one
--> tests/ui/len_zero.rs:130:8
--> tests/ui/len_zero.rs:136:8
|
LL | if has_is_empty.len() >= 1 {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:141:8
--> tests/ui/len_zero.rs:147:8
|
LL | if 0 == has_is_empty.len() {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:144:8
--> tests/ui/len_zero.rs:150:8
|
LL | if 0 != has_is_empty.len() {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:147:8
--> tests/ui/len_zero.rs:153:8
|
LL | if 0 < has_is_empty.len() {
| ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to one
--> tests/ui/len_zero.rs:150:8
--> tests/ui/len_zero.rs:156:8
|
LL | if 1 <= has_is_empty.len() {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to one
--> tests/ui/len_zero.rs:153:8
--> tests/ui/len_zero.rs:159:8
|
LL | if 1 > has_is_empty.len() {
| ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:167:8
--> tests/ui/len_zero.rs:173:8
|
LL | if with_is_empty.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `with_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:179:6
--> tests/ui/len_zero.rs:185:6
|
LL | (has_is_empty.len() > 0).then(|| println!("This can happen."));
| ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:180:6
--> tests/ui/len_zero.rs:186:6
|
LL | (has_is_empty.len() == 0).then(|| println!("Or this!"));
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `has_is_empty.is_empty()`
error: length comparison to zero
--> tests/ui/len_zero.rs:184:8
--> tests/ui/len_zero.rs:190:8
|
LL | if b.len() != 0 {}
| ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!b.is_empty()`

View file

@ -1,4 +1,5 @@
#![warn(clippy::needless_bitwise_bool)]
#![allow(clippy::const_is_empty)]
fn returns_bool() -> bool {
true

View file

@ -1,4 +1,5 @@
#![warn(clippy::needless_bitwise_bool)]
#![allow(clippy::const_is_empty)]
fn returns_bool() -> bool {
true

View file

@ -1,5 +1,5 @@
error: use of bitwise operator instead of lazy operator between booleans
--> tests/ui/needless_bitwise_bool.rs:22:8
--> tests/ui/needless_bitwise_bool.rs:23:8
|
LL | if y & !x {
| ^^^^^^ help: try: `y && !x`

View file

@ -1,4 +1,5 @@
#![warn(clippy::redundant_as_str)]
#![allow(clippy::const_is_empty)]
fn main() {
let string = "Hello, world!".to_owned();

View file

@ -1,4 +1,5 @@
#![warn(clippy::redundant_as_str)]
#![allow(clippy::const_is_empty)]
fn main() {
let string = "Hello, world!".to_owned();

View file

@ -1,5 +1,5 @@
error: this `as_str` is redundant and can be removed as the method immediately following exists on `String` too
--> tests/ui/redundant_as_str.rs:7:29
--> tests/ui/redundant_as_str.rs:8:29
|
LL | let _redundant = string.as_str().as_bytes();
| ^^^^^^^^^^^^^^^^^ help: try: `as_bytes`
@ -8,7 +8,7 @@ LL | let _redundant = string.as_str().as_bytes();
= help: to override `-D warnings` add `#[allow(clippy::redundant_as_str)]`
error: this `as_str` is redundant and can be removed as the method immediately following exists on `String` too
--> tests/ui/redundant_as_str.rs:8:29
--> tests/ui/redundant_as_str.rs:9:29
|
LL | let _redundant = string.as_str().is_empty();
| ^^^^^^^^^^^^^^^^^ help: try: `is_empty`