Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 07:00:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Whitelist unused attribute for use items.

Browse source
This commit is contained in:
mlegner 2020-03-02 10:22:05 +01:00
parent 0f4a3feccc
commit 8669be56c4
No known key found for this signature in database
GPG key ID: 8373ED3B4CCFA845
4 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
clippy_lints/src/attrs.rs
View file

@ -248,6 +248,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Attributes {
if is_word(lint, sym!(unused_imports))
|| is_word(lint, sym!(deprecated))
|| is_word(lint, sym!(unreachable_pub))
|| is_word(lint, sym!(unused))
{
return;
}

4
tests/ui/useless_attribute.fixed
View file

@ -20,6 +20,10 @@ extern crate proc_macro_derive;
#[allow(unused_imports)]
use std::collections;
// don't lint on unused for `use` items
#[allow(unused)]
use std::option;
// don't lint on deprecated for `use` items
mod foo {
#[deprecated]

4
tests/ui/useless_attribute.rs
View file

@ -20,6 +20,10 @@ extern crate proc_macro_derive;
#[allow(unused_imports)]
use std::collections;
// don't lint on unused for `use` items
#[allow(unused)]
use std::option;
// don't lint on deprecated for `use` items
mod foo {
#[deprecated]

2
tests/ui/useless_attribute.stderr
View file

@ -13,7 +13,7 @@ LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
error: useless lint attribute
--> $DIR/useless_attribute.rs:49:5
--> $DIR/useless_attribute.rs:53:5
|
LL | #[allow(clippy::almost_swapped)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(clippy::almost_swapped)]`