Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2025-02-16 05:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

missnamed_getters: use all_fields iterator

Browse source
This commit is contained in:
Sosthène Guédon 2022-11-01 19:31:47 +01:00
parent ddc49966dc
commit 81d4590834
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
clippy_lints/src/functions/missnamed_getters.rs
View file

@ -83,24 +83,9 @@ pub fn check_fn(
} }
}; };
let variants = def.variants();
// We're accessing a field, so it should be an union or a struct and have one and only one variant
if variants.len() != 1 {
if cfg!(debug_assertions) {
panic!("Struct or union expected to have only one variant");
} else {
// Don't ICE when possible
return;
}
}
let first = variants.last().unwrap();
let fields = &variants[first];
let mut used_field = None; let mut used_field = None;
let mut correct_field = None; let mut correct_field = None;
for f in &fields.fields { for f in def.all_fields() {
if f.name.as_str() == name { if f.name.as_str() == name {
correct_field = Some(f); correct_field = Some(f);
} }