mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-02-17 06:28:42 +00:00
clean tests/ui/swap.rs
Cleaning the empty lines for clarity.
This commit is contained in:
parent
a7635aa1c8
commit
80ca0484c7
2 changed files with 22 additions and 47 deletions
|
@ -12,9 +12,6 @@ fn array() {
|
|||
foo[0] = foo[1];
|
||||
foo[1] = temp;
|
||||
|
||||
|
||||
|
||||
|
||||
foo.swap(0, 1);
|
||||
}
|
||||
|
||||
|
@ -24,9 +21,6 @@ fn slice() {
|
|||
foo[0] = foo[1];
|
||||
foo[1] = temp;
|
||||
|
||||
|
||||
|
||||
|
||||
foo.swap(0, 1);
|
||||
}
|
||||
|
||||
|
@ -36,9 +30,6 @@ fn vec() {
|
|||
foo[0] = foo[1];
|
||||
foo[1] = temp;
|
||||
|
||||
|
||||
|
||||
|
||||
foo.swap(0, 1);
|
||||
}
|
||||
|
||||
|
@ -53,32 +44,16 @@ fn main() {
|
|||
a = b;
|
||||
b = a;
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
; let t = a;
|
||||
a = b;
|
||||
b = t;
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
let mut c = Foo(42);
|
||||
|
||||
c.0 = a;
|
||||
a = c.0;
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
; let t = c.0;
|
||||
c.0 = a;
|
||||
a = t;
|
||||
|
||||
|
||||
|
||||
|
||||
}
|
||||
|
|
|
@ -14,54 +14,54 @@ note: lint level defined here
|
|||
| ^^^^^^
|
||||
|
||||
error: this looks like you are swapping elements of `foo` manually
|
||||
--> $DIR/swap.rs:23:5
|
||||
--> $DIR/swap.rs:20:5
|
||||
|
|
||||
23 | / let temp = foo[0];
|
||||
24 | | foo[0] = foo[1];
|
||||
25 | | foo[1] = temp;
|
||||
20 | / let temp = foo[0];
|
||||
21 | | foo[0] = foo[1];
|
||||
22 | | foo[1] = temp;
|
||||
| |_________________^ help: try `foo.swap(0, 1)`
|
||||
|
|
||||
= note: #[deny(manual_swap)] implied by #[deny(clippy)]
|
||||
|
||||
error: this looks like you are swapping elements of `foo` manually
|
||||
--> $DIR/swap.rs:35:5
|
||||
--> $DIR/swap.rs:29:5
|
||||
|
|
||||
35 | / let temp = foo[0];
|
||||
36 | | foo[0] = foo[1];
|
||||
37 | | foo[1] = temp;
|
||||
29 | / let temp = foo[0];
|
||||
30 | | foo[0] = foo[1];
|
||||
31 | | foo[1] = temp;
|
||||
| |_________________^ help: try `foo.swap(0, 1)`
|
||||
|
|
||||
= note: #[deny(manual_swap)] implied by #[deny(clippy)]
|
||||
|
||||
error: this looks like you are swapping `a` and `b` manually
|
||||
--> $DIR/swap.rs:60:7
|
||||
--> $DIR/swap.rs:47:7
|
||||
|
|
||||
60 | ; let t = a;
|
||||
47 | ; let t = a;
|
||||
| _______^
|
||||
61 | | a = b;
|
||||
62 | | b = t;
|
||||
48 | | a = b;
|
||||
49 | | b = t;
|
||||
| |_________^ help: try `std::mem::swap(&mut a, &mut b)`
|
||||
|
|
||||
= note: #[deny(manual_swap)] implied by #[deny(clippy)]
|
||||
= note: or maybe you should use `std::mem::replace`?
|
||||
|
||||
error: this looks like you are swapping `c.0` and `a` manually
|
||||
--> $DIR/swap.rs:77:7
|
||||
--> $DIR/swap.rs:56:7
|
||||
|
|
||||
77 | ; let t = c.0;
|
||||
56 | ; let t = c.0;
|
||||
| _______^
|
||||
78 | | c.0 = a;
|
||||
79 | | a = t;
|
||||
57 | | c.0 = a;
|
||||
58 | | a = t;
|
||||
| |_________^ help: try `std::mem::swap(&mut c.0, &mut a)`
|
||||
|
|
||||
= note: #[deny(manual_swap)] implied by #[deny(clippy)]
|
||||
= note: or maybe you should use `std::mem::replace`?
|
||||
|
||||
error: this looks like you are trying to swap `a` and `b`
|
||||
--> $DIR/swap.rs:53:5
|
||||
--> $DIR/swap.rs:44:5
|
||||
|
|
||||
53 | / a = b;
|
||||
54 | | b = a;
|
||||
44 | / a = b;
|
||||
45 | | b = a;
|
||||
| |_________^ help: try `std::mem::swap(&mut a, &mut b)`
|
||||
|
|
||||
= note: #[deny(almost_swapped)] implied by #[deny(clippy)]
|
||||
|
@ -73,10 +73,10 @@ note: lint level defined here
|
|||
= note: or maybe you should use `std::mem::replace`?
|
||||
|
||||
error: this looks like you are trying to swap `c.0` and `a`
|
||||
--> $DIR/swap.rs:70:5
|
||||
--> $DIR/swap.rs:53:5
|
||||
|
|
||||
70 | / c.0 = a;
|
||||
71 | | a = c.0;
|
||||
53 | / c.0 = a;
|
||||
54 | | a = c.0;
|
||||
| |___________^ help: try `std::mem::swap(&mut c.0, &mut a)`
|
||||
|
|
||||
= note: #[deny(almost_swapped)] implied by #[deny(clippy)]
|
||||
|
|
Loading…
Add table
Reference in a new issue