mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-02-25 11:57:25 +00:00
Split match_single_binding
tests in 2 files (too many lines for CI)
This commit is contained in:
parent
00a2d7ad7e
commit
7d45d8a29a
6 changed files with 109 additions and 90 deletions
|
@ -115,33 +115,4 @@ fn main() {
|
||||||
// =>
|
// =>
|
||||||
_ => println!("Not an array index start"),
|
_ => println!("Not an array index start"),
|
||||||
}
|
}
|
||||||
// Lint (additional curly braces needed, see #6572)
|
|
||||||
struct AppendIter<I>
|
|
||||||
where
|
|
||||||
I: Iterator,
|
|
||||||
{
|
|
||||||
inner: Option<(I, <I as Iterator>::Item)>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(dead_code)]
|
|
||||||
fn size_hint<I: Iterator>(iter: &AppendIter<I>) -> (usize, Option<usize>) {
|
|
||||||
match &iter.inner {
|
|
||||||
Some((iter, _item)) => {
|
|
||||||
let (min, max) = iter.size_hint();
|
|
||||||
(min.saturating_add(1), max.and_then(|max| max.checked_add(1)))
|
|
||||||
},
|
|
||||||
None => (0, Some(0)),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
// Lint (no additional curly braces needed)
|
|
||||||
let opt = Some((5, 2));
|
|
||||||
let get_tup = || -> (i32, i32) { (1, 2) };
|
|
||||||
match opt {
|
|
||||||
#[rustfmt::skip]
|
|
||||||
Some((first, _second)) => {
|
|
||||||
let (a, b) = get_tup();
|
|
||||||
println!("a {:?} and b {:?}", a, b);
|
|
||||||
},
|
|
||||||
None => println!("nothing"),
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -132,33 +132,4 @@ fn main() {
|
||||||
// =>
|
// =>
|
||||||
_ => println!("Not an array index start"),
|
_ => println!("Not an array index start"),
|
||||||
}
|
}
|
||||||
// Lint (additional curly braces needed, see #6572)
|
|
||||||
struct AppendIter<I>
|
|
||||||
where
|
|
||||||
I: Iterator,
|
|
||||||
{
|
|
||||||
inner: Option<(I, <I as Iterator>::Item)>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(dead_code)]
|
|
||||||
fn size_hint<I: Iterator>(iter: &AppendIter<I>) -> (usize, Option<usize>) {
|
|
||||||
match &iter.inner {
|
|
||||||
Some((iter, _item)) => match iter.size_hint() {
|
|
||||||
(min, max) => (min.saturating_add(1), max.and_then(|max| max.checked_add(1))),
|
|
||||||
},
|
|
||||||
None => (0, Some(0)),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
// Lint (no additional curly braces needed)
|
|
||||||
let opt = Some((5, 2));
|
|
||||||
let get_tup = || -> (i32, i32) { (1, 2) };
|
|
||||||
match opt {
|
|
||||||
#[rustfmt::skip]
|
|
||||||
Some((first, _second)) => {
|
|
||||||
match get_tup() {
|
|
||||||
(a, b) => println!("a {:?} and b {:?}", a, b),
|
|
||||||
}
|
|
||||||
},
|
|
||||||
None => println!("nothing"),
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -178,36 +178,5 @@ LL | | _ => println!("Single branch"),
|
||||||
LL | | }
|
LL | | }
|
||||||
| |_____^ help: consider using the match body instead: `println!("Single branch");`
|
| |_____^ help: consider using the match body instead: `println!("Single branch");`
|
||||||
|
|
||||||
error: this match could be written as a `let` statement
|
error: aborting due to 12 previous errors
|
||||||
--> $DIR/match_single_binding.rs:146:36
|
|
||||||
|
|
|
||||||
LL | Some((iter, _item)) => match iter.size_hint() {
|
|
||||||
| ____________________________________^
|
|
||||||
LL | | (min, max) => (min.saturating_add(1), max.and_then(|max| max.checked_add(1))),
|
|
||||||
LL | | },
|
|
||||||
| |_____________^
|
|
||||||
|
|
|
||||||
help: consider using `let` statement
|
|
||||||
|
|
|
||||||
LL | Some((iter, _item)) => {
|
|
||||||
LL | let (min, max) = iter.size_hint();
|
|
||||||
LL | (min.saturating_add(1), max.and_then(|max| max.checked_add(1)))
|
|
||||||
LL | },
|
|
||||||
|
|
|
||||||
|
|
||||||
error: this match could be written as a `let` statement
|
|
||||||
--> $DIR/match_single_binding.rs:158:13
|
|
||||||
|
|
|
||||||
LL | / match get_tup() {
|
|
||||||
LL | | (a, b) => println!("a {:?} and b {:?}", a, b),
|
|
||||||
LL | | }
|
|
||||||
| |_____________^
|
|
||||||
|
|
|
||||||
help: consider using `let` statement
|
|
||||||
|
|
|
||||||
LL | let (a, b) = get_tup();
|
|
||||||
LL | println!("a {:?} and b {:?}", a, b);
|
|
||||||
|
|
|
||||||
|
|
||||||
error: aborting due to 14 previous errors
|
|
||||||
|
|
||||||
|
|
37
tests/ui/match_single_binding2.fixed
Normal file
37
tests/ui/match_single_binding2.fixed
Normal file
|
@ -0,0 +1,37 @@
|
||||||
|
// run-rustfix
|
||||||
|
|
||||||
|
#![warn(clippy::match_single_binding)]
|
||||||
|
#![allow(unused_variables)]
|
||||||
|
|
||||||
|
fn main() {
|
||||||
|
// Lint (additional curly braces needed, see #6572)
|
||||||
|
struct AppendIter<I>
|
||||||
|
where
|
||||||
|
I: Iterator,
|
||||||
|
{
|
||||||
|
inner: Option<(I, <I as Iterator>::Item)>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[allow(dead_code)]
|
||||||
|
fn size_hint<I: Iterator>(iter: &AppendIter<I>) -> (usize, Option<usize>) {
|
||||||
|
match &iter.inner {
|
||||||
|
Some((iter, _item)) => {
|
||||||
|
let (min, max) = iter.size_hint();
|
||||||
|
(min.saturating_add(1), max.and_then(|max| max.checked_add(1)))
|
||||||
|
},
|
||||||
|
None => (0, Some(0)),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Lint (no additional curly braces needed)
|
||||||
|
let opt = Some((5, 2));
|
||||||
|
let get_tup = || -> (i32, i32) { (1, 2) };
|
||||||
|
match opt {
|
||||||
|
#[rustfmt::skip]
|
||||||
|
Some((first, _second)) => {
|
||||||
|
let (a, b) = get_tup();
|
||||||
|
println!("a {:?} and b {:?}", a, b);
|
||||||
|
},
|
||||||
|
None => println!("nothing"),
|
||||||
|
}
|
||||||
|
}
|
37
tests/ui/match_single_binding2.rs
Normal file
37
tests/ui/match_single_binding2.rs
Normal file
|
@ -0,0 +1,37 @@
|
||||||
|
// run-rustfix
|
||||||
|
|
||||||
|
#![warn(clippy::match_single_binding)]
|
||||||
|
#![allow(unused_variables)]
|
||||||
|
|
||||||
|
fn main() {
|
||||||
|
// Lint (additional curly braces needed, see #6572)
|
||||||
|
struct AppendIter<I>
|
||||||
|
where
|
||||||
|
I: Iterator,
|
||||||
|
{
|
||||||
|
inner: Option<(I, <I as Iterator>::Item)>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[allow(dead_code)]
|
||||||
|
fn size_hint<I: Iterator>(iter: &AppendIter<I>) -> (usize, Option<usize>) {
|
||||||
|
match &iter.inner {
|
||||||
|
Some((iter, _item)) => match iter.size_hint() {
|
||||||
|
(min, max) => (min.saturating_add(1), max.and_then(|max| max.checked_add(1))),
|
||||||
|
},
|
||||||
|
None => (0, Some(0)),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Lint (no additional curly braces needed)
|
||||||
|
let opt = Some((5, 2));
|
||||||
|
let get_tup = || -> (i32, i32) { (1, 2) };
|
||||||
|
match opt {
|
||||||
|
#[rustfmt::skip]
|
||||||
|
Some((first, _second)) => {
|
||||||
|
match get_tup() {
|
||||||
|
(a, b) => println!("a {:?} and b {:?}", a, b),
|
||||||
|
}
|
||||||
|
},
|
||||||
|
None => println!("nothing"),
|
||||||
|
}
|
||||||
|
}
|
34
tests/ui/match_single_binding2.stderr
Normal file
34
tests/ui/match_single_binding2.stderr
Normal file
|
@ -0,0 +1,34 @@
|
||||||
|
error: this match could be written as a `let` statement
|
||||||
|
--> $DIR/match_single_binding2.rs:18:36
|
||||||
|
|
|
||||||
|
LL | Some((iter, _item)) => match iter.size_hint() {
|
||||||
|
| ____________________________________^
|
||||||
|
LL | | (min, max) => (min.saturating_add(1), max.and_then(|max| max.checked_add(1))),
|
||||||
|
LL | | },
|
||||||
|
| |_____________^
|
||||||
|
|
|
||||||
|
= note: `-D clippy::match-single-binding` implied by `-D warnings`
|
||||||
|
help: consider using `let` statement
|
||||||
|
|
|
||||||
|
LL | Some((iter, _item)) => {
|
||||||
|
LL | let (min, max) = iter.size_hint();
|
||||||
|
LL | (min.saturating_add(1), max.and_then(|max| max.checked_add(1)))
|
||||||
|
LL | },
|
||||||
|
|
|
||||||
|
|
||||||
|
error: this match could be written as a `let` statement
|
||||||
|
--> $DIR/match_single_binding2.rs:31:13
|
||||||
|
|
|
||||||
|
LL | / match get_tup() {
|
||||||
|
LL | | (a, b) => println!("a {:?} and b {:?}", a, b),
|
||||||
|
LL | | }
|
||||||
|
| |_____________^
|
||||||
|
|
|
||||||
|
help: consider using `let` statement
|
||||||
|
|
|
||||||
|
LL | let (a, b) = get_tup();
|
||||||
|
LL | println!("a {:?} and b {:?}", a, b);
|
||||||
|
|
|
||||||
|
|
||||||
|
error: aborting due to 2 previous errors
|
||||||
|
|
Loading…
Add table
Reference in a new issue