From 79b0ad7441970dee66ebbdec9271ed8a6ea07944 Mon Sep 17 00:00:00 2001 From: mcarton Date: Thu, 3 Mar 2016 20:09:31 +0100 Subject: [PATCH] `vec!` now uses `box` --- src/vec.rs | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/vec.rs b/src/vec.rs index fe3c1f901..dda552bc8 100644 --- a/src/vec.rs +++ b/src/vec.rs @@ -3,7 +3,7 @@ use rustc::middle::ty::TypeVariants; use rustc_front::hir::*; use syntax::codemap::Span; use syntax::ptr::P; -use utils::{BOX_NEW_PATH, VEC_FROM_ELEM_PATH}; +use utils::VEC_FROM_ELEM_PATH; use utils::{is_expn_of, match_path, snippet, span_lint_and_then}; /// **What it does:** This lint warns about using `&vec![..]` when using `&[..]` would be possible. @@ -33,9 +33,7 @@ impl LintPass for UselessVec { impl LateLintPass for UselessVec { fn check_expr(&mut self, cx: &LateContext, expr: &Expr) { - unexpand_vec(cx, expr); - - // search for `&!vec[_]` expressions where the adjusted type is `&[_]` + // search for `&vec![_]` expressions where the adjusted type is `&[_]` if_let_chain!{[ let TypeVariants::TyRef(_, ref ty) = cx.tcx.expr_ty_adjusted(expr).sty, let TypeVariants::TySlice(..) = ty.ty.sty, @@ -71,7 +69,7 @@ impl LateLintPass for UselessVec { /// Represent the pre-expansion arguments of a `vec!` invocation. pub enum VecArgs<'a> { - /// `vec![elem, len]` + /// `vec![elem; len]` Repeat(&'a P, &'a P), /// `vec![a, b, c]` Vec(&'a [P]), @@ -91,10 +89,8 @@ pub fn unexpand_vec<'e>(cx: &LateContext, expr: &'e Expr) -> Option> else if match_path(path, &["into_vec"]) && args.len() == 1 { // `vec![a, b, c]` case if_let_chain!{[ - let ExprCall(ref fun, ref args) = args[0].node, - let ExprPath(_, ref path) = fun.node, - match_path(path, &BOX_NEW_PATH) && args.len() == 1, - let ExprVec(ref args) = args[0].node + let ExprBox(ref boxed) = args[0].node, + let ExprVec(ref args) = boxed.node ], { return Some(VecArgs::Vec(&*args)); }}