Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-26 22:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix map_clone with deref and clone

Browse source
This commit is contained in:
Cameron Steffen 2020-10-30 09:18:16 -05:00
parent 040d0ca4da
commit 769094410a
3 changed files with 23 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
clippy_lints/src/map_clone.rs
View file

@ -8,6 +8,7 @@ use rustc_hir as hir;
use rustc_lint::{LateContext, LateLintPass}; use rustc_lint::{LateContext, LateLintPass};
use rustc_middle::mir::Mutability; use rustc_middle::mir::Mutability;
use rustc_middle::ty; use rustc_middle::ty;
use rustc_middle::ty::adjustment::Adjust;
use rustc_session::{declare_lint_pass, declare_tool_lint}; use rustc_session::{declare_lint_pass, declare_tool_lint};
use rustc_span::symbol::Ident; use rustc_span::symbol::Ident;
use rustc_span::{sym, Span}; use rustc_span::{sym, Span};
@ -75,11 +76,14 @@ impl<'tcx> LateLintPass<'tcx> for MapClone {
} }
} }
}, },
hir::ExprKind::MethodCall(ref method, _, ref obj, _) => { hir::ExprKind::MethodCall(ref method, _, [obj], _) => if_chain! {
if ident_eq(name, &obj[0]) && method.ident.as_str() == "clone" if ident_eq(name, obj) && method.ident.name == sym::clone;
&& match_trait_method(cx, closure_expr, &paths::CLONE_TRAIT) { if match_trait_method(cx, closure_expr, &paths::CLONE_TRAIT);
// no autoderefs
let obj_ty = cx.typeck_results().expr_ty(&obj[0]); if !cx.typeck_results().expr_adjustments(obj).iter()
.any(|a| matches!(a.kind, Adjust::Deref(Some(..))));
then {
let obj_ty = cx.typeck_results().expr_ty(obj);
if let ty::Ref(_, ty, mutability) = obj_ty.kind() { if let ty::Ref(_, ty, mutability) = obj_ty.kind() {
if matches!(mutability, Mutability::Not) { if matches!(mutability, Mutability::Not) {
let copy = is_copy(cx, ty); let copy = is_copy(cx, ty);

7
tests/ui/map_clone.fixed
View file

@ -52,4 +52,11 @@ fn main() {
let items = vec![&mut aa, &mut bb]; let items = vec![&mut aa, &mut bb];
let _: Vec<_> = items.into_iter().map(|x| x.clone()).collect(); let _: Vec<_> = items.into_iter().map(|x| x.clone()).collect();
} }
// Issue #6239 deref coercion and clone deref
{
use std::cell::RefCell;
let _ = Some(RefCell::new(String::new()).borrow()).map(|s| s.clone());
}
} }

7
tests/ui/map_clone.rs
View file

@ -52,4 +52,11 @@ fn main() {
let items = vec![&mut aa, &mut bb]; let items = vec![&mut aa, &mut bb];
let _: Vec<_> = items.into_iter().map(|x| x.clone()).collect(); let _: Vec<_> = items.into_iter().map(|x| x.clone()).collect();
} }
// Issue #6239 deref coercion and clone deref
{
use std::cell::RefCell;
let _ = Some(RefCell::new(String::new()).borrow()).map(|s| s.clone());
}
} }