Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 21:23:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(lint): check const context

Browse source 
https://github.com/rust-lang/rust-clippy/issues/8898
This commit is contained in:
kyoto7250 2022-05-28 14:33:06 +09:00
parent b97784fd07
commit 6fd2c6de90
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clippy_lints/src/checked_conversions.rs
View file

@ -2,7 +2,7 @@
use clippy_utils::diagnostics::span_lint_and_sugg;
use clippy_utils::source::snippet_with_applicability;
use clippy_utils::{meets_msrv, msrvs, SpanlessEq};
use clippy_utils::{in_constant, meets_msrv, msrvs, SpanlessEq};
use if_chain::if_chain;
use rustc_ast::ast::LitKind;
use rustc_errors::Applicability;
@ -61,6 +61,7 @@ impl<'tcx> LateLintPass<'tcx> for CheckedConversions {
}
let result = if_chain! {
if !in_constant(cx, item.hir_id);
if !in_external_macro(cx.sess(), item.span);
if let ExprKind::Binary(op, left, right) = &item.kind;

5
tests/ui/checked_conversions.fixed
View file

@ -71,4 +71,9 @@ pub fn i8_to_u8(value: i8) {
let _ = value >= 0;
}
// Do not lint
pub const fn issue_8898(i: u32) -> bool {
i <= i32::MAX as u32
}
fn main() {}

5
tests/ui/checked_conversions.rs
View file

@ -71,4 +71,9 @@ pub fn i8_to_u8(value: i8) {
let _ = value >= 0;
}
// Do not lint
pub const fn issue_8898(i: u32) -> bool {
i <= i32::MAX as u32
}
fn main() {}