Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 23:20:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Extract common logic to function

Browse source
This commit is contained in:
Alessio Cosenza 2023-05-19 17:45:49 +02:00
parent 6776608f21
commit 6f26df1c9a
No known key found for this signature in database
GPG key ID: 785AB79082BB23C2
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
clippy_lints/src/redundant_type_annotations.rs
View file

@ -111,6 +111,17 @@ fn is_redundant_in_func_call<'tcx>(
false
}
fn extract_primty<'tcx>(ty_kind: &hir::TyKind<'tcx>) -> Option<hir::PrimTy> {
if let hir::TyKind::Path(ty_path) = ty_kind
&& let hir::QPath::Resolved(_, resolved_path_ty) = ty_path
&& let hir::def::Res::PrimTy(primty) = resolved_path_ty.res
{
Some(primty)
} else {
None
}
}
impl LateLintPass<'_> for RedundantTypeAnnotations {
fn check_local<'tcx>(&mut self, cx: &LateContext<'tcx>, local: &'tcx rustc_hir::Local<'tcx>) {
// type annotation part
@ -144,14 +155,10 @@ impl LateLintPass<'_> for RedundantTypeAnnotations {
// When the initialization is a path for example u32::MAX
hir::ExprKind::Path(init_path) => {
// TODO: check for non primty
if let hir::TyKind::Path(ty_path) = &ty.kind
&& let hir::QPath::Resolved(_, resolved_path_ty) = ty_path
&& let hir::def::Res::PrimTy(primty) = resolved_path_ty.res
if let Some(primty) = extract_primty(&ty.kind)
&& let hir::QPath::TypeRelative(init_ty, _) = init_path
&& let hir::TyKind::Path(init_ty_path) = &init_ty.kind
&& let hir::QPath::Resolved(_, resolved_init_ty_path) = init_ty_path
&& let hir::def::Res::PrimTy(primty_init) = resolved_init_ty_path.res
&& let Some(primty_init) = extract_primty(&init_ty.kind)
&& primty == primty_init
{