Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 23:20:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

while_immutable_cond: check condition for mutation

Browse source
This commit is contained in:
Andre Bogus 2021-04-29 10:10:58 +02:00
parent ce37099bd3
commit 63425de77d
2 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
clippy_lints/src/loops/while_immutable_condition.rs
View file

@ -28,11 +28,14 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, cond: &'tcx Expr<'_>, expr: &'
return;
}
let used_in_condition = &var_visitor.ids;
let no_cond_variable_mutated = if let Some(used_mutably) = mutated_variables(expr, cx) {
used_in_condition.is_disjoint(&used_mutably)
} else {
return;
};
let mutated_in_body = mutated_variables(expr, cx);
let mutated_in_condition = mutated_variables(cond, cx);
let no_cond_variable_mutated =
if let (Some(used_mutably_body), Some(used_mutably_cond)) = (mutated_in_body, mutated_in_condition) {
used_in_condition.is_disjoint(&used_mutably_body) && used_in_condition.is_disjoint(&used_mutably_cond)
} else {
return;
};
let mutable_static_in_cond = var_visitor.def_ids.iter().any(|(_, v)| *v);
let mut has_break_or_return_visitor = HasBreakOrReturnVisitor {

12
tests/ui/infinite_loop.rs
View file

@ -192,11 +192,23 @@ fn while_loop_with_break_and_return() {
}
}
fn immutable_condition_false_positive(mut n: u64) -> u32 {
let mut count = 0;
while {
n >>= 1;
n != 0
} {
count += 1;
}
count
}
fn main() {
immutable_condition();
unused_var();
used_immutable();
internally_mutable();
immutable_condition_false_positive(5);
let mut c = Counter { count: 0 };
c.inc_n(5);