Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve needless_borrowed_ref and add suggestion to it.

Browse source
This commit is contained in:
Benoît CORTIER 2017-07-01 12:01:39 +02:00 committed by Oliver Schneider
parent d170e765de
commit 60ca61ee66
No known key found for this signature in database
GPG key ID: A69F8D225B3AD7D9
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
clippy_lints/src/needless_borrowed_ref.rs
View file

@ -3,9 +3,14 @@
//! This lint is **warn** by default
use rustc::lint::*;
<<<<<<< HEAD
use rustc::hir::{MutImmutable, Pat, PatKind, BindingAnnotation};
=======
use rustc::hir::{MutImmutable, Pat, PatKind};
>>>>>>> e30bf721... Improve needless_borrowed_ref and add suggestion to it.
use rustc::ty;
use utils::{span_lint, in_macro};
use utils::{span_lint_and_then, in_macro, snippet};
use syntax_pos::{Span, BytePos};
/// **What it does:** Checks for useless borrowed references.
///
@ -53,9 +58,18 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessBorrowedRef {
// Pattern's type is a reference. Get the type and mutability of referenced value (tam: TypeAndMut).
let ty::TyRef(_, ref tam) = cx.tables.pat_ty(pat).sty,
// Only lint immutable refs, because `&mut ref T` may be useful.
tam.mutbl == MutImmutable,
let PatKind::Ref(ref sub_pat, MutImmutable) = pat.node,
// Check sub_pat got a 'ref' keyword.
let ty::TyRef(_, _) = cx.tables.pat_ty(sub_pat).sty,
], {
span_lint(cx, NEEDLESS_BORROWED_REFERENCE, pat.span, "this pattern takes a reference on something that is being de-referenced")
let part_to_keep = Span{ lo: pat.span.lo + BytePos(5), hi: pat.span.hi, ctxt: pat.span.ctxt };
span_lint_and_then(cx, NEEDLESS_BORROWED_REFERENCE, pat.span,
"this pattern takes a reference on something that is being de-referenced",
|db| {
let hint = snippet(cx, part_to_keep, "..").into_owned();
db.span_suggestion(pat.span, "try removing the `&ref` part and just keep", hint);
});
}}
}
}