From 543858d741a54c882c71b3e7ef6b1cfdf02f9c7d Mon Sep 17 00:00:00 2001 From: Philipp Hansch Date: Sat, 13 Apr 2019 09:53:57 +0200 Subject: [PATCH 1/2] Update changelog for Rust 1.34.0 --- CHANGELOG.md | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7837b899b..d5913bd9d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,34 @@ All notable changes to this project will be documented in this file. ## Unreleased / In Rust Beta or Nightly -[1b89724...master](https://github.com/rust-lang/rust-clippy/compare/1b89724...master) +[1fac380...master](https://github.com/rust-lang/rust-clippy/compare/1fac380...master) + +## Rust 1.34 (2019-04-10) + +[1b89724...1fac380](https://github.com/rust-lang/rust-clippy/compare/1b89724...1fac380) + +* New lint: [`assertions_on_constants`] to detect for example `assert!(true)` +* New lint: [`dbg_macro`] to detect uses of the `dbg!` macro +* New lint: [`missing_const_for_fn`] that can suggest functions to be made `const` +* New lint: [`too_many_lines`] to detect functions with excessive LOC +* New lint: [`wildcard_enum_match_arm`] to check for wildcard enum matches using `_` +* Expand `redundant_closure` to also work for methods (not only functions) +* Fix ICEs in `vec_box`, `needless_pass_by_value` and `implicit_hasher` +* Fix false positive in `cast_sign_loss` +* Fix false positive in `integer_arithmetic` +* Fix false positive in `unit_arg` +* Fix false positives in `implicit_return` +* Add suggestion to `explicit_write` +* Improve suggestions for `question_mark` lint +* Fix incorrect suggestion for `cast_lossless` +* Fix incorrect suggestion for `expect_fun_call` +* Fix incorrect suggestion for `needless_bool` +* Fix incorrect suggestion for `needless_range_loop` +* Fix incorrect suggestion for `use_self` +* Fix incorrect suggestion for `while_let_on_iterator` +* Clippy is now slightly easier to invoke in non-cargo contexts. See + [#3665][pull3665] for more details. +* We now have [improved documentation][adding_lints] on how to add new lints ## Rust 1.33 (2019-02-26) @@ -763,6 +790,8 @@ All notable changes to this project will be documented in this file. [`AsMut`]: https://doc.rust-lang.org/std/convert/trait.AsMut.html [`AsRef`]: https://doc.rust-lang.org/std/convert/trait.AsRef.html [configuration file]: ./rust-clippy#configuration +[pull3665]: https://github.com/rust-lang/rust-clippy/pull/3665 +[adding_lints]: https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md [`absurd_extreme_comparisons`]: https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons From 745d6fb74be66d2e44457ca345bb34ce0118ef2f Mon Sep 17 00:00:00 2001 From: Philipp Hansch Date: Sat, 13 Apr 2019 11:04:58 +0200 Subject: [PATCH 2/2] Mention configuration option for too_many_lines lint --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5913bd9d..d15755d4c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,8 @@ All notable changes to this project will be documented in this file. * New lint: [`assertions_on_constants`] to detect for example `assert!(true)` * New lint: [`dbg_macro`] to detect uses of the `dbg!` macro * New lint: [`missing_const_for_fn`] that can suggest functions to be made `const` -* New lint: [`too_many_lines`] to detect functions with excessive LOC +* New lint: [`too_many_lines`] to detect functions with excessive LOC. It can be + configured using the `too-many-lines-threshold` configuration. * New lint: [`wildcard_enum_match_arm`] to check for wildcard enum matches using `_` * Expand `redundant_closure` to also work for methods (not only functions) * Fix ICEs in `vec_box`, `needless_pass_by_value` and `implicit_hasher`