Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-28 07:30:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #8913 - InfRandomness:ICE-#8748, r=giraffate

Browse source 
Fix #8748

Thank you for making Clippy better!

changelog: Fix ICE #8748 in shadow.rs
This commit is contained in:
bors 2022-05-31 00:17:52 +00:00
commit 588e1982d3
2 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
clippy_lints/src/shadow.rs
View file

@ -160,9 +160,13 @@ impl<'tcx> LateLintPass<'tcx> for Shadow {
fn is_shadow(cx: &LateContext<'_>, owner: LocalDefId, first: ItemLocalId, second: ItemLocalId) -> bool {
let scope_tree = cx.tcx.region_scope_tree(owner.to_def_id());
let first_scope = scope_tree.var_scope(first).unwrap();
let second_scope = scope_tree.var_scope(second).unwrap();
scope_tree.is_subscope_of(second_scope, first_scope)
if let Some(first_scope) = scope_tree.var_scope(first) {
if let Some(second_scope) = scope_tree.var_scope(second) {
return scope_tree.is_subscope_of(second_scope, first_scope);
}
}
false
}
fn lint_shadow(cx: &LateContext<'_>, pat: &Pat<'_>, shadowed: HirId, span: Span) {

7
tests/ui/shadow.rs
View file

@ -88,4 +88,11 @@ pub async fn foo2(_a: i32, _b: i64) {
let _b = _a;
}
fn ice_8748() {
let _ = [0; {
let x = 1;
if let Some(x) = Some(1) { x } else { 1 }
}];
}
fn main() {}