Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-30 08:30:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove unused attribute in test

Browse source
This commit is contained in:
Lzu Tao 2019-09-26 01:53:39 +00:00
parent 08ce6bc6d9
commit 5639639d35
3 changed files with 27 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tests/ui/toplevel_ref_arg.fixed
View file

@ -1,27 +1,26 @@
// run-rustfix
#![warn(clippy::toplevel_ref_arg)]
#![allow(unused)]
fn main() {
// Closures should not warn
let y = |ref x| println!("{:?}", x);
y(1u8);
let x = &1;
let _x = &1;
let y: &(&_, u8) = &(&1, 2);
let _y: &(&_, u8) = &(&1, 2);
let z = &(1 + 2);
let _z = &(1 + 2);
let z = &mut (1 + 2);
let _z = &mut (1 + 2);
let (ref x, _) = (1, 2); // ok, not top level
println!("The answer is {}.", x);
let x = &vec![1, 2, 3];
let _x = &vec![1, 2, 3];
// Make sure that allowing the lint works
#[allow(clippy::toplevel_ref_arg)]
let ref mut x = 1_234_543;
let ref mut _x = 1_234_543;
}

13
tests/ui/toplevel_ref_arg.rs
View file

@ -1,27 +1,26 @@
// run-rustfix
#![warn(clippy::toplevel_ref_arg)]
#![allow(unused)]
fn main() {
// Closures should not warn
let y = |ref x| println!("{:?}", x);
y(1u8);
let ref x = 1;
let ref _x = 1;
let ref y: (&_, u8) = (&1, 2);
let ref _y: (&_, u8) = (&1, 2);
let ref z = 1 + 2;
let ref _z = 1 + 2;
let ref mut z = 1 + 2;
let ref mut _z = 1 + 2;
let (ref x, _) = (1, 2); // ok, not top level
println!("The answer is {}.", x);
let ref x = vec![1, 2, 3];
let ref _x = vec![1, 2, 3];
// Make sure that allowing the lint works
#[allow(clippy::toplevel_ref_arg)]
let ref mut x = 1_234_543;
let ref mut _x = 1_234_543;
}

30
tests/ui/toplevel_ref_arg.stderr
View file

@ -1,34 +1,34 @@
error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
--> $DIR/toplevel_ref_arg.rs:11:9
--> $DIR/toplevel_ref_arg.rs:10:9
|
LL | let ref x = 1;
| ----^^^^^----- help: try: `let x = &1;`
LL | let ref _x = 1;
| ----^^^^^^----- help: try: `let _x = &1;`
|
= note: `-D clippy::toplevel-ref-arg` implied by `-D warnings`
error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
--> $DIR/toplevel_ref_arg.rs:13:9
--> $DIR/toplevel_ref_arg.rs:12:9
|
LL | let ref y: (&_, u8) = (&1, 2);
| ----^^^^^--------------------- help: try: `let y: &(&_, u8) = &(&1, 2);`
LL | let ref _y: (&_, u8) = (&1, 2);
| ----^^^^^^--------------------- help: try: `let _y: &(&_, u8) = &(&1, 2);`
error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
--> $DIR/toplevel_ref_arg.rs:15:9
--> $DIR/toplevel_ref_arg.rs:14:9
|
LL | let ref z = 1 + 2;
| ----^^^^^--------- help: try: `let z = &(1 + 2);`
LL | let ref _z = 1 + 2;
| ----^^^^^^--------- help: try: `let _z = &(1 + 2);`
error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
--> $DIR/toplevel_ref_arg.rs:17:9
--> $DIR/toplevel_ref_arg.rs:16:9
|
LL | let ref mut z = 1 + 2;
| ----^^^^^^^^^--------- help: try: `let z = &mut (1 + 2);`
LL | let ref mut _z = 1 + 2;
| ----^^^^^^^^^^--------- help: try: `let _z = &mut (1 + 2);`
error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
--> $DIR/toplevel_ref_arg.rs:22:9
--> $DIR/toplevel_ref_arg.rs:21:9
|
LL | let ref x = vec![1, 2, 3];
| ----^^^^^----------------- help: try: `let x = &vec![1, 2, 3];`
LL | let ref _x = vec![1, 2, 3];
| ----^^^^^^----------------- help: try: `let _x = &vec![1, 2, 3];`
error: aborting due to 5 previous errors