Don't trigger toplevel_ref_arg for for loops

This commit is contained in:
Shotaro Yamada 2020-04-19 22:56:47 +09:00
parent f6b07db385
commit 554f47bb48
3 changed files with 8 additions and 1 deletions

View file

@ -14,7 +14,7 @@ use rustc_span::source_map::{ExpnKind, Span};
use crate::consts::{constant, Constant};
use crate::utils::sugg::Sugg;
use crate::utils::{
get_item_name, get_parent_expr, implements_trait, in_constant, is_integer_const, iter_input_pats,
get_item_name, get_parent_expr, higher, implements_trait, in_constant, is_integer_const, iter_input_pats,
last_path_segment, match_qpath, match_trait_method, paths, snippet, snippet_opt, span_lint, span_lint_and_sugg,
span_lint_and_then, span_lint_hir_and_then, walk_ptrs_ty, SpanlessEq,
};
@ -267,6 +267,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MiscLints {
if let StmtKind::Local(ref local) = stmt.kind;
if let PatKind::Binding(an, .., name, None) = local.pat.kind;
if let Some(ref init) = local.init;
if !higher::is_from_for_desugar(local);
then {
if an == BindingAnnotation::Ref || an == BindingAnnotation::RefMut {
let sugg_init = if init.span.from_expansion() {

View file

@ -23,4 +23,7 @@ fn main() {
// Make sure that allowing the lint works
#[allow(clippy::toplevel_ref_arg)]
let ref mut _x = 1_234_543;
// ok
for ref _x in 0..10 {}
}

View file

@ -23,4 +23,7 @@ fn main() {
// Make sure that allowing the lint works
#[allow(clippy::toplevel_ref_arg)]
let ref mut _x = 1_234_543;
// ok
for ref _x in 0..10 {}
}