Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 21:23:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix accidental newline in diagnostic and missing entries in lint_array!

Browse source
This commit is contained in:
Oliver Schneider 2017-03-24 10:21:12 +01:00
parent 8ae82eb4ab
commit 5547fbb770
2 changed files with 23 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
clippy_lints/src/drop_forget_ref.rs
View file

@ -89,13 +89,13 @@ declare_lint! {
"calls to `std::mem::forget` with a value that implements Copy" "calls to `std::mem::forget` with a value that implements Copy"
} }
const DROP_REF_SUMMARY: &str = "calls to `std::mem::drop` with a reference instead of an owned value. const DROP_REF_SUMMARY: &str = "calls to `std::mem::drop` with a reference instead of an owned value. \
Dropping a reference does nothing."; Dropping a reference does nothing.";
const FORGET_REF_SUMMARY: &str = "calls to `std::mem::forget` with a reference instead of an owned value. const FORGET_REF_SUMMARY: &str = "calls to `std::mem::forget` with a reference instead of an owned value. \
Forgetting a reference does nothing."; Forgetting a reference does nothing.";
const DROP_COPY_SUMMARY: &str = "calls to `std::mem::drop` with a value that implements Copy. const DROP_COPY_SUMMARY: &str = "calls to `std::mem::drop` with a value that implements Copy. \
Dropping a copy leaves the original intact."; Dropping a copy leaves the original intact.";
const FORGET_COPY_SUMMARY: &str = "calls to `std::mem::forget` with a value that implements Copy. const FORGET_COPY_SUMMARY: &str = "calls to `std::mem::forget` with a value that implements Copy. \
Forgetting a copy leaves the original intact."; Forgetting a copy leaves the original intact.";
#[allow(missing_copy_implementations)] #[allow(missing_copy_implementations)]
@ -103,7 +103,7 @@ pub struct Pass;
impl LintPass for Pass { impl LintPass for Pass {
fn get_lints(&self) -> LintArray { fn get_lints(&self) -> LintArray {
lint_array!(DROP_REF, FORGET_REF) lint_array!(DROP_REF, FORGET_REF, DROP_COPY, FORGET_COPY)
} }
} }

36
tests/ui/drop_forget_ref.stderr
View file

@ -1,4 +1,4 @@
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:12:5 --> $DIR/drop_forget_ref.rs:12:5
| |
12 | drop(&SomeStruct); 12 | drop(&SomeStruct);
@ -15,7 +15,7 @@ note: argument has type &SomeStruct
12 | drop(&SomeStruct); 12 | drop(&SomeStruct);
| ^^^^^^^^^^^ | ^^^^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:13:5 --> $DIR/drop_forget_ref.rs:13:5
| |
13 | forget(&SomeStruct); 13 | forget(&SomeStruct);
@ -32,7 +32,7 @@ note: argument has type &SomeStruct
13 | forget(&SomeStruct); 13 | forget(&SomeStruct);
| ^^^^^^^^^^^ | ^^^^^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:16:5 --> $DIR/drop_forget_ref.rs:16:5
| |
16 | drop(&owned1); 16 | drop(&owned1);
@ -44,7 +44,7 @@ note: argument has type &SomeStruct
16 | drop(&owned1); 16 | drop(&owned1);
| ^^^^^^^ | ^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:17:5 --> $DIR/drop_forget_ref.rs:17:5
| |
17 | drop(&&owned1); 17 | drop(&&owned1);
@ -56,7 +56,7 @@ note: argument has type &&SomeStruct
17 | drop(&&owned1); 17 | drop(&&owned1);
| ^^^^^^^^ | ^^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:18:5 --> $DIR/drop_forget_ref.rs:18:5
| |
18 | drop(&mut owned1); 18 | drop(&mut owned1);
@ -68,7 +68,7 @@ note: argument has type &mut SomeStruct
18 | drop(&mut owned1); 18 | drop(&mut owned1);
| ^^^^^^^^^^^ | ^^^^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:21:5 --> $DIR/drop_forget_ref.rs:21:5
| |
21 | forget(&owned2); 21 | forget(&owned2);
@ -80,7 +80,7 @@ note: argument has type &SomeStruct
21 | forget(&owned2); 21 | forget(&owned2);
| ^^^^^^^ | ^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:22:5 --> $DIR/drop_forget_ref.rs:22:5
| |
22 | forget(&&owned2); 22 | forget(&&owned2);
@ -92,7 +92,7 @@ note: argument has type &&SomeStruct
22 | forget(&&owned2); 22 | forget(&&owned2);
| ^^^^^^^^ | ^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:23:5 --> $DIR/drop_forget_ref.rs:23:5
| |
23 | forget(&mut owned2); 23 | forget(&mut owned2);
@ -104,7 +104,7 @@ note: argument has type &mut SomeStruct
23 | forget(&mut owned2); 23 | forget(&mut owned2);
| ^^^^^^^^^^^ | ^^^^^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:27:5 --> $DIR/drop_forget_ref.rs:27:5
| |
27 | drop(reference1); 27 | drop(reference1);
@ -116,7 +116,7 @@ note: argument has type &SomeStruct
27 | drop(reference1); 27 | drop(reference1);
| ^^^^^^^^^^ | ^^^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:28:5 --> $DIR/drop_forget_ref.rs:28:5
| |
28 | forget(&*reference1); 28 | forget(&*reference1);
@ -128,7 +128,7 @@ note: argument has type &SomeStruct
28 | forget(&*reference1); 28 | forget(&*reference1);
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:31:5 --> $DIR/drop_forget_ref.rs:31:5
| |
31 | drop(reference2); 31 | drop(reference2);
@ -140,7 +140,7 @@ note: argument has type &mut SomeStruct
31 | drop(reference2); 31 | drop(reference2);
| ^^^^^^^^^^ | ^^^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:33:5 --> $DIR/drop_forget_ref.rs:33:5
| |
33 | forget(reference3); 33 | forget(reference3);
@ -152,7 +152,7 @@ note: argument has type &mut SomeStruct
33 | forget(reference3); 33 | forget(reference3);
| ^^^^^^^^^^ | ^^^^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:36:5 --> $DIR/drop_forget_ref.rs:36:5
| |
36 | drop(reference4); 36 | drop(reference4);
@ -164,7 +164,7 @@ note: argument has type &SomeStruct
36 | drop(reference4); 36 | drop(reference4);
| ^^^^^^^^^^ | ^^^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:37:5 --> $DIR/drop_forget_ref.rs:37:5
| |
37 | forget(reference4); 37 | forget(reference4);
@ -176,7 +176,7 @@ note: argument has type &SomeStruct
37 | forget(reference4); 37 | forget(reference4);
| ^^^^^^^^^^ | ^^^^^^^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:42:5 --> $DIR/drop_forget_ref.rs:42:5
| |
42 | drop(&val); 42 | drop(&val);
@ -188,7 +188,7 @@ note: argument has type &T
42 | drop(&val); 42 | drop(&val);
| ^^^^ | ^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:48:5 --> $DIR/drop_forget_ref.rs:48:5
| |
48 | forget(&val); 48 | forget(&val);
@ -200,7 +200,7 @@ note: argument has type &T
48 | forget(&val); 48 | forget(&val);
| ^^^^ | ^^^^
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing.
--> $DIR/drop_forget_ref.rs:56:5 --> $DIR/drop_forget_ref.rs:56:5
| |
56 | std::mem::drop(&SomeStruct); 56 | std::mem::drop(&SomeStruct);
@ -212,7 +212,7 @@ note: argument has type &SomeStruct
56 | std::mem::drop(&SomeStruct); 56 | std::mem::drop(&SomeStruct);
| ^^^^^^^^^^^ | ^^^^^^^^^^^
error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing.
--> $DIR/drop_forget_ref.rs:59:5 --> $DIR/drop_forget_ref.rs:59:5
| |
59 | std::mem::forget(&SomeStruct); 59 | std::mem::forget(&SomeStruct);