Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 13:13:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove author requirement for cargo_common_metadata

Browse source
This commit is contained in:
daxpedda 2021-04-03 22:52:48 +02:00
parent 86fb0e8266
commit 5102c9cc69
No known key found for this signature in database
GPG key ID: 43D62A3EA388E46F
5 changed files with 8 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
clippy_lints/src/cargo_common_metadata.rs
View file

@ -20,11 +20,10 @@ declare_clippy_lint! {
/// ///
/// **Example:** /// **Example:**
/// ```toml /// ```toml
/// # This `Cargo.toml` is missing an authors field: /// # This `Cargo.toml` is missing a description field:
/// [package] /// [package]
/// name = "clippy" /// name = "clippy"
/// version = "0.0.212" /// version = "0.0.212"
/// description = "A bunch of helpful lints to avoid common pitfalls in Rust"
/// repository = "https://github.com/rust-lang/rust-clippy" /// repository = "https://github.com/rust-lang/rust-clippy"
/// readme = "README.md" /// readme = "README.md"
/// license = "MIT OR Apache-2.0" /// license = "MIT OR Apache-2.0"
@ -32,14 +31,13 @@ declare_clippy_lint! {
/// categories = ["development-tools", "development-tools::cargo-plugins"] /// categories = ["development-tools", "development-tools::cargo-plugins"]
/// ``` /// ```
/// ///
/// Should include an authors field like: /// Should include a description field like:
/// ///
/// ```toml /// ```toml
/// # This `Cargo.toml` includes all common metadata /// # This `Cargo.toml` includes all common metadata
/// [package] /// [package]
/// name = "clippy" /// name = "clippy"
/// version = "0.0.212" /// version = "0.0.212"
/// authors = ["Someone <someone@rust-lang.org>"]
/// description = "A bunch of helpful lints to avoid common pitfalls in Rust" /// description = "A bunch of helpful lints to avoid common pitfalls in Rust"
/// repository = "https://github.com/rust-lang/rust-clippy" /// repository = "https://github.com/rust-lang/rust-clippy"
/// readme = "README.md" /// readme = "README.md"
@ -97,10 +95,6 @@ impl LateLintPass<'_> for CargoCommonMetadata {
// only run the lint if publish is `None` (`publish = true` or skipped entirely) // only run the lint if publish is `None` (`publish = true` or skipped entirely)
// or if the vector isn't empty (`publish = ["something"]`) // or if the vector isn't empty (`publish = ["something"]`)
if package.publish.as_ref().filter(|publish| publish.is_empty()).is_none() || self.ignore_publish { if package.publish.as_ref().filter(|publish| publish.is_empty()).is_none() || self.ignore_publish {
if is_empty_vec(&package.authors) {
missing_warning(cx, &package, "package.authors");
}
if is_empty_str(&package.description) { if is_empty_str(&package.description) {
missing_warning(cx, &package, "package.description"); missing_warning(cx, &package, "package.description");
} }

6
tests/ui-cargo/cargo_common_metadata/fail/src/main.stderr
View file

@ -1,9 +1,7 @@
error: package `cargo_common_metadata` is missing `package.authors` metadata error: package `cargo_common_metadata` is missing `package.description` metadata
| |
= note: `-D clippy::cargo-common-metadata` implied by `-D warnings` = note: `-D clippy::cargo-common-metadata` implied by `-D warnings`
error: package `cargo_common_metadata` is missing `package.description` metadata
error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata
error: package `cargo_common_metadata` is missing `package.repository` metadata error: package `cargo_common_metadata` is missing `package.repository` metadata
@ -14,5 +12,5 @@ error: package `cargo_common_metadata` is missing `package.keywords` metadata
error: package `cargo_common_metadata` is missing `package.categories` metadata error: package `cargo_common_metadata` is missing `package.categories` metadata
error: aborting due to 7 previous errors error: aborting due to 6 previous errors

6
tests/ui-cargo/cargo_common_metadata/fail_publish/src/main.stderr
View file

@ -1,9 +1,7 @@
error: package `cargo_common_metadata` is missing `package.authors` metadata error: package `cargo_common_metadata` is missing `package.description` metadata
| |
= note: `-D clippy::cargo-common-metadata` implied by `-D warnings` = note: `-D clippy::cargo-common-metadata` implied by `-D warnings`
error: package `cargo_common_metadata` is missing `package.description` metadata
error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata
error: package `cargo_common_metadata` is missing `package.repository` metadata error: package `cargo_common_metadata` is missing `package.repository` metadata
@ -14,5 +12,5 @@ error: package `cargo_common_metadata` is missing `package.keywords` metadata
error: package `cargo_common_metadata` is missing `package.categories` metadata error: package `cargo_common_metadata` is missing `package.categories` metadata
error: aborting due to 7 previous errors error: aborting due to 6 previous errors

6
tests/ui-cargo/cargo_common_metadata/fail_publish_true/src/main.stderr
View file

@ -1,9 +1,7 @@
error: package `cargo_common_metadata` is missing `package.authors` metadata error: package `cargo_common_metadata` is missing `package.description` metadata
| |
= note: `-D clippy::cargo-common-metadata` implied by `-D warnings` = note: `-D clippy::cargo-common-metadata` implied by `-D warnings`
error: package `cargo_common_metadata` is missing `package.description` metadata
error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata
error: package `cargo_common_metadata` is missing `package.repository` metadata error: package `cargo_common_metadata` is missing `package.repository` metadata
@ -14,5 +12,5 @@ error: package `cargo_common_metadata` is missing `package.keywords` metadata
error: package `cargo_common_metadata` is missing `package.categories` metadata error: package `cargo_common_metadata` is missing `package.categories` metadata
error: aborting due to 7 previous errors error: aborting due to 6 previous errors

1
tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
View file

@ -2,7 +2,6 @@
name = "cargo_common_metadata" name = "cargo_common_metadata"
version = "0.1.0" version = "0.1.0"
publish = false publish = false
authors = ["Random person from the Internet <someone@someplace.org>"]
description = "A test package for the cargo_common_metadata lint" description = "A test package for the cargo_common_metadata lint"
repository = "https://github.com/someone/cargo_common_metadata" repository = "https://github.com/someone/cargo_common_metadata"
readme = "README.md" readme = "README.md"