Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 23:20:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

needless_range_loop: improve documentation

Browse source
This commit is contained in:
Tyler Weaver 2023-01-29 11:41:53 -07:00
parent 96c28d1f69
commit 4d266d31de
No known key found for this signature in database
3 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clippy_lints/src/loops/mod.rs
View file

@ -61,7 +61,8 @@ declare_clippy_lint! {
/// ///
/// ### Why is this bad? /// ### Why is this bad?
/// Just iterating the collection itself makes the intent /// Just iterating the collection itself makes the intent
/// more clear and is probably faster. /// more clear and is probably faster because it eliminates
/// the bounds check that is done when indexing.
/// ///
/// ### Example /// ### Example
/// ```rust /// ```rust

2
clippy_lints/src/loops/needless_range_loop.rs
View file

@ -149,7 +149,7 @@ pub(super) fn check<'tcx>(
|diag| { |diag| {
multispan_sugg( multispan_sugg(
diag, diag,
"consider using an iterator", "consider using an iterator and enumerate",
vec![ vec![
(pat.span, format!("({}, <item>)", ident.name)), (pat.span, format!("({}, <item>)", ident.name)),
( (

8
tests/ui/needless_range_loop.stderr
View file

@ -49,7 +49,7 @@ error: the loop variable `i` is used to index `vec`
LL | for i in 0..vec.len() { LL | for i in 0..vec.len() {
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
| |
help: consider using an iterator help: consider using an iterator and enumerate
| |
LL | for (i, <item>) in vec.iter().enumerate() { LL | for (i, <item>) in vec.iter().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
@ -126,7 +126,7 @@ error: the loop variable `i` is used to index `vec`
LL | for i in 5..vec.len() { LL | for i in 5..vec.len() {
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
| |
help: consider using an iterator help: consider using an iterator and enumerate
| |
LL | for (i, <item>) in vec.iter().enumerate().skip(5) { LL | for (i, <item>) in vec.iter().enumerate().skip(5) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@ -137,7 +137,7 @@ error: the loop variable `i` is used to index `vec`
LL | for i in 5..10 { LL | for i in 5..10 {
| ^^^^^ | ^^^^^
| |
help: consider using an iterator help: consider using an iterator and enumerate
| |
LL | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) { LL | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@ -148,7 +148,7 @@ error: the loop variable `i` is used to index `vec`
LL | for i in 0..vec.len() { LL | for i in 0..vec.len() {
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
| |
help: consider using an iterator help: consider using an iterator and enumerate
| |
LL | for (i, <item>) in vec.iter_mut().enumerate() { LL | for (i, <item>) in vec.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~