Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-10 15:14:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Ensure expect_fun_call bad suggestion is fixed

Browse source 
Closes #3839
This commit is contained in:
Michael Wright 2019-03-06 07:00:05 +02:00
parent a8f61e70a8
commit 464ed58861
3 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/ui/expect_fun_call.fixed
View file

@ -81,4 +81,7 @@ fn main() {
Some("foo").unwrap_or_else(|| { panic!(get_static_str()) });
Some("foo").unwrap_or_else(|| { panic!(get_non_static_str(&0).to_string()) });
}
//Issue #3839
Some(true).unwrap_or_else(|| panic!("key {}, {}", 1, 2));
}

3
tests/ui/expect_fun_call.rs
View file

@ -81,4 +81,7 @@ fn main() {
Some("foo").expect(get_static_str());
Some("foo").expect(get_non_static_str(&0));
}
//Issue #3839
Some(true).expect(&format!("key {}, {}", 1, 2));
}

8
tests/ui/expect_fun_call.stderr
View file

@ -60,5 +60,11 @@ error: use of `expect` followed by a function call
LL | Some("foo").expect(get_non_static_str(&0));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { panic!(get_non_static_str(&0).to_string()) })`
error: aborting due to 10 previous errors
error: use of `expect` followed by a function call
--> $DIR/expect_fun_call.rs:86:16
|
LL | Some(true).expect(&format!("key {}, {}", 1, 2));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("key {}, {}", 1, 2))`
error: aborting due to 11 previous errors