Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2025-02-20 07:58:44 +00:00
Code Issues Projects Releases Packages Wiki Activity

methods: lint against String.to_string (fixes #100)

Browse source
This commit is contained in:
Georg Brandl 2015-08-12 17:02:49 +02:00
parent 6ff1e9a766
commit 4074c1f968
3 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/lib.rs
View file

@ -83,5 +83,6 @@ pub fn plugin_registrar(reg: &mut Registry) {
methods::OPTION_UNWRAP_USED, methods::OPTION_UNWRAP_USED,
methods::RESULT_UNWRAP_USED, methods::RESULT_UNWRAP_USED,
methods::STR_TO_STRING, methods::STR_TO_STRING,
methods::STRING_TO_STRING,
]); ]);
} }

10
src/methods.rs
View file

@ -13,10 +13,12 @@ declare_lint!(pub RESULT_UNWRAP_USED, Allow,
"Warn on using unwrap() on a Result value"); "Warn on using unwrap() on a Result value");
declare_lint!(pub STR_TO_STRING, Warn, declare_lint!(pub STR_TO_STRING, Warn,
"Warn when a String could use to_owned() instead of to_string()"); "Warn when a String could use to_owned() instead of to_string()");
declare_lint!(pub STRING_TO_STRING, Warn,
"Warn when calling String.to_string()");
impl LintPass for MethodsPass { impl LintPass for MethodsPass {
fn get_lints(&self) -> LintArray { fn get_lints(&self) -> LintArray {
lint_array!(OPTION_UNWRAP_USED, RESULT_UNWRAP_USED, STR_TO_STRING) lint_array!(OPTION_UNWRAP_USED, RESULT_UNWRAP_USED, STR_TO_STRING, STRING_TO_STRING)
} }
fn check_expr(&mut self, cx: &Context, expr: &Expr) { fn check_expr(&mut self, cx: &Context, expr: &Expr) {
@ -41,6 +43,12 @@ impl LintPass for MethodsPass {
if let ty::TyStr = *obj_ty { if let ty::TyStr = *obj_ty {
span_lint(cx, STR_TO_STRING, expr.span, "`str.to_owned()` is faster"); span_lint(cx, STR_TO_STRING, expr.span, "`str.to_owned()` is faster");
} }
else if let ty::TyStruct(did, _) = *obj_ty {
if match_def_path(cx, did.did, &["collections", "string", "String"]) {
span_lint(cx, STRING_TO_STRING, expr.span,
"`String.to_string()` is a no-op")
}
}
} }
} }
} }

4
tests/compile-fail/methods.rs
View file

@ -2,10 +2,14 @@
#![plugin(clippy)] #![plugin(clippy)]
#[deny(option_unwrap_used, result_unwrap_used)] #[deny(option_unwrap_used, result_unwrap_used)]
#[deny(str_to_string, string_to_string)]
fn main() { fn main() {
let opt = Some(0); let opt = Some(0);
let _ = opt.unwrap(); //~ERROR let _ = opt.unwrap(); //~ERROR
let res: Result<i32, ()> = Ok(0); let res: Result<i32, ()> = Ok(0);
let _ = res.unwrap(); //~ERROR let _ = res.unwrap(); //~ERROR
let string = "str".to_string(); //~ERROR
let _again = string.to_string(); //~ERROR
} }