mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-26 06:30:32 +00:00
Implement release subcommand in clippy_dev
This is a QoL improvement for doing releases. The `release bump_version` subcommand increments the version in all relevant `Cargo.toml` files. The `release commit` command will only work with the new Josh syncs. Until then the old way, using `git log` has to be used.
This commit is contained in:
parent
802c016cdd
commit
3ec2859cf2
7 changed files with 112 additions and 1 deletions
|
@ -1,6 +1,8 @@
|
||||||
[package]
|
[package]
|
||||||
name = "clippy"
|
name = "clippy"
|
||||||
|
# begin autogenerated version
|
||||||
version = "0.1.84"
|
version = "0.1.84"
|
||||||
|
# end autogenerated version
|
||||||
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
|
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
|
||||||
repository = "https://github.com/rust-lang/rust-clippy"
|
repository = "https://github.com/rust-lang/rust-clippy"
|
||||||
readme = "README.md"
|
readme = "README.md"
|
||||||
|
|
|
@ -1,6 +1,8 @@
|
||||||
[package]
|
[package]
|
||||||
name = "clippy_config"
|
name = "clippy_config"
|
||||||
|
# begin autogenerated version
|
||||||
version = "0.1.84"
|
version = "0.1.84"
|
||||||
|
# end autogenerated version
|
||||||
edition = "2021"
|
edition = "2021"
|
||||||
publish = false
|
publish = false
|
||||||
|
|
||||||
|
|
|
@ -18,6 +18,7 @@ pub mod dogfood;
|
||||||
pub mod fmt;
|
pub mod fmt;
|
||||||
pub mod lint;
|
pub mod lint;
|
||||||
pub mod new_lint;
|
pub mod new_lint;
|
||||||
|
pub mod release;
|
||||||
pub mod serve;
|
pub mod serve;
|
||||||
pub mod setup;
|
pub mod setup;
|
||||||
pub mod sync;
|
pub mod sync;
|
||||||
|
|
|
@ -3,7 +3,7 @@
|
||||||
#![warn(rust_2018_idioms, unused_lifetimes)]
|
#![warn(rust_2018_idioms, unused_lifetimes)]
|
||||||
|
|
||||||
use clap::{Args, Parser, Subcommand};
|
use clap::{Args, Parser, Subcommand};
|
||||||
use clippy_dev::{dogfood, fmt, lint, new_lint, serve, setup, sync, update_lints, utils};
|
use clippy_dev::{dogfood, fmt, lint, new_lint, release, serve, setup, sync, update_lints, utils};
|
||||||
use std::convert::Infallible;
|
use std::convert::Infallible;
|
||||||
|
|
||||||
fn main() {
|
fn main() {
|
||||||
|
@ -84,6 +84,10 @@ fn main() {
|
||||||
force,
|
force,
|
||||||
} => sync::rustc_push(repo_path, &user, &branch, force),
|
} => sync::rustc_push(repo_path, &user, &branch, force),
|
||||||
},
|
},
|
||||||
|
DevCommand::Release(ReleaseCommand { subcommand }) => match subcommand {
|
||||||
|
ReleaseSubcommand::BumpVersion => release::bump_version(),
|
||||||
|
ReleaseSubcommand::Commit { repo_path, branch } => release::rustc_clippy_commit(repo_path, branch),
|
||||||
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -236,6 +240,8 @@ enum DevCommand {
|
||||||
},
|
},
|
||||||
/// Sync between the rust repo and the Clippy repo
|
/// Sync between the rust repo and the Clippy repo
|
||||||
Sync(SyncCommand),
|
Sync(SyncCommand),
|
||||||
|
/// Manage Clippy releases
|
||||||
|
Release(ReleaseCommand),
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Args)]
|
#[derive(Args)]
|
||||||
|
@ -330,3 +336,23 @@ enum SyncSubcommand {
|
||||||
force: bool,
|
force: bool,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Args)]
|
||||||
|
struct ReleaseCommand {
|
||||||
|
#[command(subcommand)]
|
||||||
|
subcommand: ReleaseSubcommand,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Subcommand)]
|
||||||
|
enum ReleaseSubcommand {
|
||||||
|
#[command(name = "bump_version")]
|
||||||
|
/// Bump the version in the Cargo.toml files
|
||||||
|
BumpVersion,
|
||||||
|
/// Print the Clippy commit in the rustc repo for the specified branch
|
||||||
|
Commit {
|
||||||
|
/// The path to a rustc repo to look for the commit
|
||||||
|
repo_path: String,
|
||||||
|
/// For which branch to print the commit
|
||||||
|
branch: release::Branch,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
76
clippy_dev/src/release.rs
Normal file
76
clippy_dev/src/release.rs
Normal file
|
@ -0,0 +1,76 @@
|
||||||
|
use std::fmt::{Display, Write};
|
||||||
|
use std::path::Path;
|
||||||
|
|
||||||
|
use crate::sync::PUSH_PR_DESCRIPTION;
|
||||||
|
use crate::utils::{clippy_version, replace_region_in_file, UpdateMode};
|
||||||
|
|
||||||
|
use clap::ValueEnum;
|
||||||
|
use xshell::{cmd, Shell};
|
||||||
|
|
||||||
|
const CARGO_TOML_FILES: [&str; 5] = [
|
||||||
|
"clippy_config/Cargo.toml",
|
||||||
|
"clippy_lints/Cargo.toml",
|
||||||
|
"clippy_utils/Cargo.toml",
|
||||||
|
"declare_clippy_lint/Cargo.toml",
|
||||||
|
"Cargo.toml",
|
||||||
|
];
|
||||||
|
|
||||||
|
pub fn bump_version() {
|
||||||
|
let (minor, mut patch) = clippy_version();
|
||||||
|
patch += 1;
|
||||||
|
for file in &CARGO_TOML_FILES {
|
||||||
|
replace_region_in_file(
|
||||||
|
UpdateMode::Change,
|
||||||
|
Path::new(file),
|
||||||
|
"# begin autogenerated version\n",
|
||||||
|
"# end autogenerated version",
|
||||||
|
|res| {
|
||||||
|
writeln!(res, "version = \"0.{minor}.{patch}\"").unwrap();
|
||||||
|
},
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(ValueEnum, Copy, Clone)]
|
||||||
|
pub enum Branch {
|
||||||
|
Stable,
|
||||||
|
Beta,
|
||||||
|
Master,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Display for Branch {
|
||||||
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
||||||
|
match self {
|
||||||
|
Branch::Stable => write!(f, "stable"),
|
||||||
|
Branch::Beta => write!(f, "beta"),
|
||||||
|
Branch::Master => write!(f, "master"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn rustc_clippy_commit(rustc_path: String, branch: Branch) {
|
||||||
|
let sh = Shell::new().expect("failed to create shell");
|
||||||
|
sh.change_dir(rustc_path);
|
||||||
|
|
||||||
|
let base = branch.to_string();
|
||||||
|
cmd!(sh, "git fetch https://github.com/rust-lang/rust {base}")
|
||||||
|
.run()
|
||||||
|
.expect("failed to fetch base commit");
|
||||||
|
let last_rustup_commit = cmd!(
|
||||||
|
sh,
|
||||||
|
"git log -1 --merges --grep=\"{PUSH_PR_DESCRIPTION}\" FETCH_HEAD -- src/tools/clippy"
|
||||||
|
)
|
||||||
|
.read()
|
||||||
|
.expect("failed to run git log");
|
||||||
|
|
||||||
|
let commit = last_rustup_commit
|
||||||
|
.lines()
|
||||||
|
.find(|c| c.contains("Sync from Clippy commit:"))
|
||||||
|
.expect("no commit found")
|
||||||
|
.trim()
|
||||||
|
.rsplit_once('@')
|
||||||
|
.expect("no commit hash found")
|
||||||
|
.1;
|
||||||
|
|
||||||
|
println!("{commit}");
|
||||||
|
}
|
|
@ -1,6 +1,8 @@
|
||||||
[package]
|
[package]
|
||||||
name = "clippy_lints"
|
name = "clippy_lints"
|
||||||
|
# begin autogenerated version
|
||||||
version = "0.1.84"
|
version = "0.1.84"
|
||||||
|
# end autogenerated version
|
||||||
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
|
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
|
||||||
repository = "https://github.com/rust-lang/rust-clippy"
|
repository = "https://github.com/rust-lang/rust-clippy"
|
||||||
readme = "README.md"
|
readme = "README.md"
|
||||||
|
|
|
@ -1,6 +1,8 @@
|
||||||
[package]
|
[package]
|
||||||
name = "clippy_utils"
|
name = "clippy_utils"
|
||||||
|
# begin autogenerated version
|
||||||
version = "0.1.84"
|
version = "0.1.84"
|
||||||
|
# end autogenerated version
|
||||||
edition = "2021"
|
edition = "2021"
|
||||||
description = "Helpful tools for writing lints, provided as they are used in Clippy"
|
description = "Helpful tools for writing lints, provided as they are used in Clippy"
|
||||||
repository = "https://github.com/rust-lang/rust-clippy"
|
repository = "https://github.com/rust-lang/rust-clippy"
|
||||||
|
|
Loading…
Reference in a new issue