From 3737abe802dc4c0f776634499bc666d6446a64c7 Mon Sep 17 00:00:00 2001 From: DevAccentor Date: Sun, 5 Jun 2022 10:26:29 +0200 Subject: [PATCH] change based on review --- tests/ui/for_loops_over_fallibles.rs | 4 ++-- tests/ui/for_loops_over_fallibles.stderr | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/ui/for_loops_over_fallibles.rs b/tests/ui/for_loops_over_fallibles.rs index bde78a9fd..3390111d0 100644 --- a/tests/ui/for_loops_over_fallibles.rs +++ b/tests/ui/for_loops_over_fallibles.rs @@ -21,12 +21,12 @@ fn for_loops_over_fallibles() { } // check over a `Result` - for x in result.into_iter() { + for x in result.iter_mut() { println!("{}", x); } // check over a `Result` - for x in result.iter_mut() { + for x in result.into_iter() { println!("{}", x); } diff --git a/tests/ui/for_loops_over_fallibles.stderr b/tests/ui/for_loops_over_fallibles.stderr index 635e08182..8c8c02224 100644 --- a/tests/ui/for_loops_over_fallibles.stderr +++ b/tests/ui/for_loops_over_fallibles.stderr @@ -26,19 +26,19 @@ LL | for x in result { error: for loop over `result`, which is a `Result`. This is more readably written as an `if let` statement --> $DIR/for_loops_over_fallibles.rs:24:14 | -LL | for x in result.into_iter() { - | ^^^^^^ - | - = help: consider replacing `for x in result.into_iter()` with `if let Ok(x) = result` - -error: for loop over `result`, which is a `Result`. This is more readably written as an `if let` statement - --> $DIR/for_loops_over_fallibles.rs:29:14 - | LL | for x in result.iter_mut() { | ^^^^^^ | = help: consider replacing `for x in result.iter_mut()` with `if let Ok(x) = result` +error: for loop over `result`, which is a `Result`. This is more readably written as an `if let` statement + --> $DIR/for_loops_over_fallibles.rs:29:14 + | +LL | for x in result.into_iter() { + | ^^^^^^ + | + = help: consider replacing `for x in result.into_iter()` with `if let Ok(x) = result` + error: for loop over `option.ok_or("x not found")`, which is a `Result`. This is more readably written as an `if let` statement --> $DIR/for_loops_over_fallibles.rs:33:14 |