Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 13:13:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't lint slice type annotations for byte strings

Browse source
This commit is contained in:
Bruno Andreotti 2024-01-30 16:17:02 -03:00
parent 455c07b7cc
commit 3106219e24
No known key found for this signature in database
GPG key ID: 12C66EC2BECC600C
3 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
clippy_lints/src/redundant_type_annotations.rs
View file

@ -188,7 +188,6 @@ impl LateLintPass<'_> for RedundantTypeAnnotations {
match init_lit.node {
// In these cases the annotation is redundant
LitKind::Str(..)
| LitKind::ByteStr(..)
| LitKind::Byte(..)
| LitKind::Char(..)
| LitKind::Bool(..)
@ -202,6 +201,16 @@ impl LateLintPass<'_> for RedundantTypeAnnotations {
}
},
LitKind::Err => (),
LitKind::ByteStr(..) => {
// We only lint if the type annotation is an array type (e.g. &[u8; 4]).
// If instead it is a slice (e.g. &[u8]) it may not be redundant, so we
// don't lint.
if let hir::TyKind::Ref(_, mut_ty) = ty.kind
&& matches!(mut_ty.ty.kind, hir::TyKind::Array(..))
{
span_lint(cx, REDUNDANT_TYPE_ANNOTATIONS, local.span, "redundant type annotation");
}
},
}
},
_ => (),

7
tests/ui/redundant_type_annotations.rs
View file

@ -196,13 +196,18 @@ fn test_simple_types() {
let _var: &str = "test";
//~^ ERROR: redundant type annotation
let _var: &[u8] = b"test";
let _var: &[u8; 4] = b"test";
//~^ ERROR: redundant type annotation
let _var: bool = false;
//~^ ERROR: redundant type annotation
}
fn issue12212() {
// This should not be linted
let _var: &[u8] = b"test";
}
fn issue11190() {}
fn main() {}

4
tests/ui/redundant_type_annotations.stderr
View file

@ -94,8 +94,8 @@ LL | let _var: &str = "test";
error: redundant type annotation
--> $DIR/redundant_type_annotations.rs:199:5
|
LL | let _var: &[u8] = b"test";
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
LL | let _var: &[u8; 4] = b"test";
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: redundant type annotation
--> $DIR/redundant_type_annotations.rs:202:5