Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

split suggestions into two separate suggestions

Browse source
This commit is contained in:
Kartavya Vashishtha 2023-02-06 21:34:35 +05:30
parent 63a57ee1c3
commit 2fc1693cd5
No known key found for this signature in database
GPG key ID: A50012C2324E5DF0
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/methods/suspicious_to_owned.rs
View file

@ -29,10 +29,16 @@ pub fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, recv: &hir::Expr<'_>) -
"this `to_owned` call clones the {input_type} itself and does not cause the {input_type} contents to become owned"
)),
|diag| {
diag.span_suggestions(
diag.span_suggestion(
expr.span,
"depending on intent, either make the Cow an Owned variant or clone the Cow itself",
[format!("{recv_snip}.into_owned()"), format!("{recv_snip}.clone()")],
"depending on intent, either make the Cow an Owned variant",
format!("{recv_snip}.into_owned()"),
app
);
diag.span_suggestion(
expr.span,
"or clone the Cow itself",
format!("{recv_snip}.clone()"),
app
);
}