Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-16 17:58:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1174 from oli-obk/bugfix

Browse source 
don't lint `unused_attribute` if snippet is shorter than 1 character
This commit is contained in:
Martin Carton 2016-08-19 17:37:21 +02:00 committed by GitHub
commit 27255bc213
2 changed files with 24 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
clippy_lints/src/attrs.rs
View file

@ -106,17 +106,29 @@ impl LateLintPass for AttrPass {
ItemExternCrate(_) |
ItemUse(_) => {
for attr in &item.attrs {
if let MetaItemKind::List(ref name, _) = attr.node.value.node {
if let MetaItemKind::List(ref name, ref lint_list) = attr.node.value.node {
match &**name {
"allow" | "warn" | "deny" | "forbid" => {
span_lint_and_then(cx, USELESS_ATTRIBUTE, attr.span,
"useless lint attribute",
|db| {
if let Some(mut sugg) = snippet_opt(cx, attr.span) {
sugg.insert(1, '!');
db.span_suggestion(attr.span, "if you just forgot a `!`, use", sugg);
// whitelist `unused_imports`
for lint in lint_list {
if let MetaItemKind::Word(ref word) = lint.node {
if word == "unused_imports" {
if let ItemUse(_) = item.node {
return;
}
}
}
});
}
if let Some(mut sugg) = snippet_opt(cx, attr.span) {
if sugg.len() > 1 {
span_lint_and_then(cx, USELESS_ATTRIBUTE, attr.span,
"useless lint attribute",
|db| {
sugg.insert(1, '!');
db.span_suggestion(attr.span, "if you just forgot a `!`, use", sugg);
});
}
}
},
_ => {},
}

4
tests/compile-fail/useless_attribute.rs
View file

@ -7,4 +7,8 @@
//~| SUGGESTION #![allow(dead_code)]
extern crate clippy_lints;
// don't lint on unused_import for `use` items
#[allow(unused_imports)]
use std::collections;
fn main() {}