Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-01 00:49:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fixed naive doc formatting for #[must_use] lints

Browse source
This commit is contained in:
Matthias Kaak 2021-10-16 15:23:34 +00:00
parent e1871ba0da
commit 25ff7ce128
2 changed files with 6 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/functions/mod.rs
View file

@ -91,11 +91,9 @@ declare_clippy_lint! {
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for a [`#[must_use]`] attribute on /// Checks for a `#[must_use]` attribute on
/// unit-returning functions and methods. /// unit-returning functions and methods.
/// ///
/// [`#[must_use]`]: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
///
/// ### Why is this bad? /// ### Why is this bad?
/// Unit values are useless. The attribute is likely /// Unit values are useless. The attribute is likely
/// a remnant of a refactoring that removed the return type. /// a remnant of a refactoring that removed the return type.
@ -112,12 +110,10 @@ declare_clippy_lint! {
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for a [`#[must_use]`] attribute without /// Checks for a `#[must_use]` attribute without
/// further information on functions and methods that return a type already /// further information on functions and methods that return a type already
/// marked as `#[must_use]`. /// marked as `#[must_use]`.
/// ///
/// [`#[must_use]`]: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
///
/// ### Why is this bad? /// ### Why is this bad?
/// The attribute isn't needed. Not using the result /// The attribute isn't needed. Not using the result
/// will already be reported. Alternatively, one can add some text to the /// will already be reported. Alternatively, one can add some text to the
@ -138,11 +134,9 @@ declare_clippy_lint! {
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for public functions that have no /// Checks for public functions that have no
/// [`#[must_use]`] attribute, but return something not already marked /// `#[must_use]` attribute, but return something not already marked
/// must-use, have no mutable arg and mutate no statics. /// must-use, have no mutable arg and mutate no statics.
/// ///
/// [`#[must_use]`]: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
///
/// ### Why is this bad? /// ### Why is this bad?
/// Not bad at all, this lint just shows places where /// Not bad at all, this lint just shows places where
/// you could add the attribute. /// you could add the attribute.

7
clippy_lints/src/let_underscore.rs
View file

@ -10,12 +10,11 @@ use rustc_session::{declare_lint_pass, declare_tool_lint};
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for `let _ = <expr>` /// Checks for `let _ = <expr>` where expr is `#[must_use]`
/// where expr is #[must_use]
/// ///
/// ### Why is this bad? /// ### Why is this bad?
/// It's better to explicitly /// It's better to explicitly handle the value of a `#[must_use]`
/// handle the value of a #[must_use] expr /// expr
/// ///
/// ### Example /// ### Example
/// ```rust /// ```rust