Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #10168 - blyxyas:fix_reversed_empty_ranges, r=dswij

Browse source 
[#10167] Clarify that the lint only works if x eq. y in a `for` loop.

Reading the documentation for the lint, one could expect that the lint works in all cases that `X == Y`. This is false.

While the lint was updated, the documentation wasn't.

More information about the `N..N` problem in #5689 and #5628

---

Fixes #10167
changelog: [`reversed_empty_ranges`]: Update and clarify documentation
This commit is contained in:
bors 2023-01-06 18:55:20 +00:00
commit 19b79c485e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/ranges.rs
View file

@ -103,7 +103,7 @@ declare_clippy_lint! {
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for range expressions `x..y` where both `x` and `y` /// Checks for range expressions `x..y` where both `x` and `y`
/// are constant and `x` is greater or equal to `y`. /// are constant and `x` is greater to `y`. Also triggers if `x` is equal to `y` when they are conditions to a `for` loop.
/// ///
/// ### Why is this bad? /// ### Why is this bad?
/// Empty ranges yield no values so iterating them is a no-op. /// Empty ranges yield no values so iterating them is a no-op.