Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-26 22:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix FP in inherent_to_string when the function has generic parameters

Browse source
This commit is contained in:
Morten Lohne 2021-02-20 23:47:49 +01:00
parent 67087a1b4e
commit 19a377510c
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
clippy_lints/src/inherent_to_string.rs
View file

@ -106,6 +106,7 @@ impl<'tcx> LateLintPass<'tcx> for InherentToString {
let decl = &signature.decl;
if decl.implicit_self.has_implicit_self();
if decl.inputs.len() == 1;
if impl_item.generics.params.is_empty();
// Check if return type is String
if is_type_diagnostic_item(cx, return_ty(cx, impl_item.hir_id), sym::string_type);

11
tests/ui/inherent_to_string.rs
View file

@ -14,6 +14,7 @@ struct C;
struct D;
struct E;
struct F;
struct G;
impl A {
// Should be detected; emit warning
@ -73,6 +74,13 @@ impl F {
}
}
impl G {
// Should not be detected, as it does not match the function signature
fn to_string<const _N: usize>(&self) -> String {
"G.to_string()".to_string()
}
}
fn main() {
let a = A;
a.to_string();
@ -93,4 +101,7 @@ fn main() {
let f = F;
f.to_string(1);
let g = G;
g.to_string::<1>();
}

4
tests/ui/inherent_to_string.stderr
View file

@ -1,5 +1,5 @@
error: implementation of inherent method `to_string(&self) -> String` for type `A`
--> $DIR/inherent_to_string.rs:20:5
--> $DIR/inherent_to_string.rs:21:5
|
LL | / fn to_string(&self) -> String {
LL | | "A.to_string()".to_string()
@ -10,7 +10,7 @@ LL | | }
= help: implement trait `Display` for type `A` instead
error: type `C` implements inherent method `to_string(&self) -> String` which shadows the implementation of `Display`
--> $DIR/inherent_to_string.rs:44:5
--> $DIR/inherent_to_string.rs:45:5
|
LL | / fn to_string(&self) -> String {
LL | | "C.to_string()".to_string()