mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-02-17 14:38:46 +00:00
don't lint similar_names inside #[test] functions
This commit is contained in:
parent
469b3d51b4
commit
10f468e679
1 changed files with 19 additions and 14 deletions
|
@ -2,7 +2,8 @@ use rustc::lint::*;
|
|||
use syntax::codemap::Span;
|
||||
use syntax::parse::token::InternedString;
|
||||
use syntax::ast::*;
|
||||
use syntax::visit::{self, FnKind};
|
||||
use syntax::attr;
|
||||
use syntax::visit;
|
||||
use utils::{span_lint_and_then, in_macro, span_lint};
|
||||
|
||||
/// **What it does:** This lint warns about names that are very similar and thus confusing
|
||||
|
@ -237,12 +238,14 @@ impl<'v, 'a, 'b> visit::Visitor<'v> for SimilarNamesLocalVisitor<'a, 'b> {
|
|||
});
|
||||
}
|
||||
fn visit_item(&mut self, _: &'v Item) {
|
||||
// do nothing
|
||||
// do not recurse into inner items
|
||||
}
|
||||
}
|
||||
|
||||
impl EarlyLintPass for NonExpressiveNames {
|
||||
fn check_fn(&mut self, cx: &EarlyContext, _: FnKind, decl: &FnDecl, blk: &Block, _: Span, _: NodeId) {
|
||||
fn check_item(&mut self, cx: &EarlyContext, item: &Item) {
|
||||
if let ItemKind::Fn(ref decl, _, _, _, _, ref blk) = item.node {
|
||||
if !attr::contains_name(&item.attrs, "test") {
|
||||
let mut visitor = SimilarNamesLocalVisitor {
|
||||
names: Vec::new(),
|
||||
cx: cx,
|
||||
|
@ -257,6 +260,8 @@ impl EarlyLintPass for NonExpressiveNames {
|
|||
visit::walk_block(&mut visitor, blk);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Precondition: `a_name.chars().count() < b_name.chars().count()`.
|
||||
fn levenstein_not_1(a_name: &str, b_name: &str) -> bool {
|
||||
|
|
Loading…
Add table
Reference in a new issue