mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 23:24:24 +00:00
unnecessary_owned_empty_string -> unnecessary_owned_empty_strings
This commit is contained in:
parent
a4d1837f07
commit
10201370a1
9 changed files with 16 additions and 16 deletions
|
@ -3650,7 +3650,7 @@ Released 2018-09-13
|
|||
[`unnecessary_lazy_evaluations`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
||||
[`unnecessary_mut_passed`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
|
||||
[`unnecessary_operation`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
|
||||
[`unnecessary_owned_empty_string`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_owned_empty_string
|
||||
[`unnecessary_owned_empty_strings`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_owned_empty_strings
|
||||
[`unnecessary_self_imports`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_self_imports
|
||||
[`unnecessary_sort_by`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
|
||||
[`unnecessary_to_owned`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
|
||||
|
|
|
@ -310,7 +310,7 @@ store.register_group(true, "clippy::all", Some("clippy_all"), vec![
|
|||
LintId::of(unit_types::UNIT_CMP),
|
||||
LintId::of(unnamed_address::FN_ADDRESS_COMPARISONS),
|
||||
LintId::of(unnamed_address::VTABLE_ADDRESS_COMPARISONS),
|
||||
LintId::of(unnecessary_owned_empty_string::UNNECESSARY_OWNED_EMPTY_STRING),
|
||||
LintId::of(unnecessary_owned_empty_strings::UNNECESSARY_OWNED_EMPTY_STRINGS),
|
||||
LintId::of(unnecessary_sort_by::UNNECESSARY_SORT_BY),
|
||||
LintId::of(unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
|
||||
LintId::of(unused_io_amount::UNUSED_IO_AMOUNT),
|
||||
|
|
|
@ -523,7 +523,7 @@ store.register_lints(&[
|
|||
unit_types::UNIT_CMP,
|
||||
unnamed_address::FN_ADDRESS_COMPARISONS,
|
||||
unnamed_address::VTABLE_ADDRESS_COMPARISONS,
|
||||
unnecessary_owned_empty_string::UNNECESSARY_OWNED_EMPTY_STRING,
|
||||
unnecessary_owned_empty_strings::UNNECESSARY_OWNED_EMPTY_STRINGS,
|
||||
unnecessary_self_imports::UNNECESSARY_SELF_IMPORTS,
|
||||
unnecessary_sort_by::UNNECESSARY_SORT_BY,
|
||||
unnecessary_wraps::UNNECESSARY_WRAPS,
|
||||
|
|
|
@ -106,7 +106,7 @@ store.register_group(true, "clippy::style", Some("clippy_style"), vec![
|
|||
LintId::of(single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS),
|
||||
LintId::of(tabs_in_doc_comments::TABS_IN_DOC_COMMENTS),
|
||||
LintId::of(to_digit_is_some::TO_DIGIT_IS_SOME),
|
||||
LintId::of(unnecessary_owned_empty_string::UNNECESSARY_OWNED_EMPTY_STRING),
|
||||
LintId::of(unnecessary_owned_empty_strings::UNNECESSARY_OWNED_EMPTY_STRINGS),
|
||||
LintId::of(unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
|
||||
LintId::of(unused_unit::UNUSED_UNIT),
|
||||
LintId::of(upper_case_acronyms::UPPER_CASE_ACRONYMS),
|
||||
|
|
|
@ -383,7 +383,7 @@ mod unit_hash;
|
|||
mod unit_return_expecting_ord;
|
||||
mod unit_types;
|
||||
mod unnamed_address;
|
||||
mod unnecessary_owned_empty_string;
|
||||
mod unnecessary_owned_empty_strings;
|
||||
mod unnecessary_self_imports;
|
||||
mod unnecessary_sort_by;
|
||||
mod unnecessary_wraps;
|
||||
|
@ -869,7 +869,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
|
|||
});
|
||||
store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
|
||||
store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
|
||||
store.register_late_pass(|| Box::new(unnecessary_owned_empty_string::UnnecessaryOwnedEmptyString));
|
||||
store.register_late_pass(|| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
|
||||
// add lints here, do not remove this comment, it's used in `new_lint`
|
||||
}
|
||||
|
||||
|
|
|
@ -27,13 +27,13 @@ declare_clippy_lint! {
|
|||
/// vec!["1", "2", "3"].join("");
|
||||
/// ```
|
||||
#[clippy::version = "1.62.0"]
|
||||
pub UNNECESSARY_OWNED_EMPTY_STRING,
|
||||
pub UNNECESSARY_OWNED_EMPTY_STRINGS,
|
||||
style,
|
||||
"detects cases of references to owned empty strings being passed as an argument to a function expecting `&str`"
|
||||
}
|
||||
declare_lint_pass!(UnnecessaryOwnedEmptyString => [UNNECESSARY_OWNED_EMPTY_STRING]);
|
||||
declare_lint_pass!(UnnecessaryOwnedEmptyStrings => [UNNECESSARY_OWNED_EMPTY_STRINGS]);
|
||||
|
||||
impl<'tcx> LateLintPass<'tcx> for UnnecessaryOwnedEmptyString {
|
||||
impl<'tcx> LateLintPass<'tcx> for UnnecessaryOwnedEmptyStrings {
|
||||
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
|
||||
if_chain! {
|
||||
if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, inner_expr) = expr.kind;
|
||||
|
@ -46,7 +46,7 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryOwnedEmptyString {
|
|||
if match_def_path(cx, fun_def_id, &paths::STRING_NEW) {
|
||||
span_lint_and_sugg(
|
||||
cx,
|
||||
UNNECESSARY_OWNED_EMPTY_STRING,
|
||||
UNNECESSARY_OWNED_EMPTY_STRINGS,
|
||||
expr.span,
|
||||
"usage of `&String::new()` for a function expecting a `&str` argument",
|
||||
"try",
|
||||
|
@ -65,7 +65,7 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryOwnedEmptyString {
|
|||
then {
|
||||
span_lint_and_sugg(
|
||||
cx,
|
||||
UNNECESSARY_OWNED_EMPTY_STRING,
|
||||
UNNECESSARY_OWNED_EMPTY_STRINGS,
|
||||
expr.span,
|
||||
"usage of `&String::from(\"\")` for a function expecting a `&str` argument",
|
||||
"try",
|
|
@ -1,6 +1,6 @@
|
|||
// run-rustfix
|
||||
|
||||
#![warn(clippy::unnecessary_owned_empty_string)]
|
||||
#![warn(clippy::unnecessary_owned_empty_strings)]
|
||||
|
||||
fn ref_str_argument(_value: &str) {}
|
||||
|
|
@ -1,6 +1,6 @@
|
|||
// run-rustfix
|
||||
|
||||
#![warn(clippy::unnecessary_owned_empty_string)]
|
||||
#![warn(clippy::unnecessary_owned_empty_strings)]
|
||||
|
||||
fn ref_str_argument(_value: &str) {}
|
||||
|
|
@ -1,13 +1,13 @@
|
|||
error: usage of `&String::new()` for a function expecting a `&str` argument
|
||||
--> $DIR/unnecessary_owned_empty_string.rs:12:22
|
||||
--> $DIR/unnecessary_owned_empty_strings.rs:12:22
|
||||
|
|
||||
LL | ref_str_argument(&String::new());
|
||||
| ^^^^^^^^^^^^^^ help: try: `""`
|
||||
|
|
||||
= note: `-D clippy::unnecessary-owned-empty-string` implied by `-D warnings`
|
||||
= note: `-D clippy::unnecessary-owned-empty-strings` implied by `-D warnings`
|
||||
|
||||
error: usage of `&String::from("")` for a function expecting a `&str` argument
|
||||
--> $DIR/unnecessary_owned_empty_string.rs:15:22
|
||||
--> $DIR/unnecessary_owned_empty_strings.rs:15:22
|
||||
|
|
||||
LL | ref_str_argument(&String::from(""));
|
||||
| ^^^^^^^^^^^^^^^^^ help: try: `""`
|
Loading…
Reference in a new issue