Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 21:23:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Change floating point constant to mem::transmute u64 comparison

Browse source
This commit is contained in:
Taylor Cramer 2016-07-13 00:59:35 -07:00
parent 8907cbc0b8
commit 0dd13b0db2
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/consts.rs
View file

@ -92,8 +92,10 @@ impl PartialEq for Constant {
// we want `Fw32 == FwAny` and `FwAny == Fw64`, by transitivity we must have
// `Fw32 == Fw64` so don’t compare them
match (ls.parse::<f64>(), rs.parse::<f64>()) {
(Ok(l), Ok(r)) => l.eq(&r) &&
(l.is_sign_positive() == r.is_sign_positive()), // needed for 0.0 != -0.0
// mem::transmute is required to catch non-matching 0.0, -0.0, and NaNs
(Ok(l), Ok(r)) => unsafe {
mem::transmute::<f64, u64>(l) == mem::transmute::<f64, u64>(r)
},
_ => false,
}
}