Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-10 15:14:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Keep old deprecated lints deprecated as non-tool, too

Browse source
This commit is contained in:
Philipp Hansch 2019-08-12 07:28:07 +02:00
parent 5114050839
commit 0b7e2376c8
No known key found for this signature in database
GPG key ID: 82AA61CAA11397E6
2 changed files with 56 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
clippy_lints/src/lib.rs
View file

@ -384,6 +384,8 @@ pub fn read_conf(reg: &rustc_plugin::Registry<'_>) -> Conf {
#[rustfmt::skip] #[rustfmt::skip]
pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
let mut store = reg.sess.lint_store.borrow_mut(); let mut store = reg.sess.lint_store.borrow_mut();
register_removed_non_tool_lints(&mut store);
// begin deprecated lints, do not remove this comment, it’s used in `update_lints` // begin deprecated lints, do not remove this comment, it’s used in `update_lints`
store.register_removed( store.register_removed(
"clippy::should_assert_eq", "clippy::should_assert_eq",
@ -1164,6 +1166,54 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
]); ]);
} }
#[rustfmt::skip]
fn register_removed_non_tool_lints(store: &mut rustc::lint::LintStore) {
store.register_removed(
"should_assert_eq",
"`assert!()` will be more flexible with RFC 2011",
);
store.register_removed(
"extend_from_slice",
"`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
);
store.register_removed(
"range_step_by_zero",
"`iterator.step_by(0)` panics nowadays",
);
store.register_removed(
"unstable_as_slice",
"`Vec::as_slice` has been stabilized in 1.7",
);
store.register_removed(
"unstable_as_mut_slice",
"`Vec::as_mut_slice` has been stabilized in 1.7",
);
store.register_removed(
"str_to_string",
"using `str::to_string` is common even today and specialization will likely happen soon",
);
store.register_removed(
"string_to_string",
"using `string::to_string` is common even today and specialization will likely happen soon",
);
store.register_removed(
"misaligned_transmute",
"this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
);
store.register_removed(
"assign_ops",
"using compound assignment operators (e.g., `+=`) is harmless",
);
store.register_removed(
"if_let_redundant_pattern_matching",
"this lint has been changed to redundant_pattern_matching",
);
store.register_removed(
"unsafe_vector_initialization",
"the replacement suggested by this lint had substantially different behavior",
);
}
/// Register renamed lints. /// Register renamed lints.
/// ///
/// Used in `./src/driver.rs`. /// Used in `./src/driver.rs`.

12
tests/ui/deprecated.rs
View file

@ -1,8 +1,8 @@
#[warn(clippy::str_to_string)] #[warn(str_to_string)]
#[warn(clippy::string_to_string)] #[warn(string_to_string)]
#[warn(clippy::unstable_as_slice)] #[warn(unstable_as_slice)]
#[warn(clippy::unstable_as_mut_slice)] #[warn(unstable_as_mut_slice)]
#[warn(clippy::misaligned_transmute)] #[warn(misaligned_transmute)]
#[warn(clippy::unused_collect)] #[warn(unused_collect)]
fn main() {} fn main() {}