Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #5170 - JohnTitor:fix-prefix, r=flip1995

Browse source 
Fix false positive in `zero_prefixed_literal`

Fixes #5169

changelog: Fix false positive in `zero_prefixed_literal`
This commit is contained in:
bors 2020-02-13 12:26:29 +00:00
commit 06777d509e
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/misc_early.rs
View file

@ -506,7 +506,11 @@ impl MiscEarlyLints {
); );
} }
if lit_snip.starts_with("0x") && maybe_last_sep_idx >= 3 { if lit_snip.starts_with("0x") {
if maybe_last_sep_idx <= 2 {
// It's meaningless or causes range error.
return;
}
let mut seen = (false, false); let mut seen = (false, false);
for ch in lit_snip.as_bytes()[2..=maybe_last_sep_idx].iter() { for ch in lit_snip.as_bytes()[2..=maybe_last_sep_idx].iter() {
match ch { match ch {

1
tests/ui/literals.rs
View file

@ -28,6 +28,7 @@ fn main() {
let ok15 = 0xab_cabc_abca_bcab_cabc; let ok15 = 0xab_cabc_abca_bcab_cabc;
let ok16 = 0xFE_BAFE_ABAB_ABCD; let ok16 = 0xFE_BAFE_ABAB_ABCD;
let ok17 = 0x123_4567_8901_usize; let ok17 = 0x123_4567_8901_usize;
let ok18 = 0xF;
let fail19 = 12_3456_21; let fail19 = 12_3456_21;
let fail22 = 3__4___23; let fail22 = 3__4___23;

6
tests/ui/literals.stderr
View file

@ -50,7 +50,7 @@ LL | let fail8 = 0o123;
| ^^^^^ | ^^^^^
error: digits grouped inconsistently by underscores error: digits grouped inconsistently by underscores
--> $DIR/literals.rs:32:18 --> $DIR/literals.rs:33:18
| |
LL | let fail19 = 12_3456_21; LL | let fail19 = 12_3456_21;
| ^^^^^^^^^^ help: consider: `12_345_621` | ^^^^^^^^^^ help: consider: `12_345_621`
@ -58,13 +58,13 @@ LL | let fail19 = 12_3456_21;
= note: `-D clippy::inconsistent-digit-grouping` implied by `-D warnings` = note: `-D clippy::inconsistent-digit-grouping` implied by `-D warnings`
error: digits grouped inconsistently by underscores error: digits grouped inconsistently by underscores
--> $DIR/literals.rs:33:18 --> $DIR/literals.rs:34:18
| |
LL | let fail22 = 3__4___23; LL | let fail22 = 3__4___23;
| ^^^^^^^^^ help: consider: `3_423` | ^^^^^^^^^ help: consider: `3_423`
error: digits grouped inconsistently by underscores error: digits grouped inconsistently by underscores
--> $DIR/literals.rs:34:18 --> $DIR/literals.rs:35:18
| |
LL | let fail23 = 3__16___23; LL | let fail23 = 3__16___23;
| ^^^^^^^^^^ help: consider: `31_623` | ^^^^^^^^^^ help: consider: `31_623`