2022-01-27 14:12:45 +00:00
|
|
|
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:13:14
|
2018-10-06 16:18:06 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn do_vec(x: &Vec<i64>) {
|
2018-10-06 16:18:06 +00:00
|
|
|
| ^^^^^^^^^ help: change this to: `&[i64]`
|
|
|
|
|
|
|
|
|
= note: `-D clippy::ptr-arg` implied by `-D warnings`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:17:18
|
2022-01-27 14:12:45 +00:00
|
|
|
|
|
|
|
|
LL | fn do_vec_mut(x: &mut Vec<i64>) {
|
|
|
|
| ^^^^^^^^^^^^^ help: change this to: `&mut [i64]`
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&String` instead of `&str` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:21:14
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn do_str(x: &String) {
|
2017-09-10 17:32:24 +00:00
|
|
|
| ^^^^^^^ help: change this to: `&str`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
error: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:25:18
|
2022-01-27 14:12:45 +00:00
|
|
|
|
|
|
|
|
LL | fn do_str_mut(x: &mut String) {
|
|
|
|
| ^^^^^^^^^^^ help: change this to: `&mut str`
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:29:15
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
LL | fn do_path(x: &PathBuf) {
|
|
|
|
| ^^^^^^^^ help: change this to: `&Path`
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
error: writing `&mut PathBuf` instead of `&mut Path` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:33:19
|
2022-01-27 14:12:45 +00:00
|
|
|
|
|
|
|
|
LL | fn do_path_mut(x: &mut PathBuf) {
|
|
|
|
| ^^^^^^^^^^^^ help: change this to: `&mut Path`
|
|
|
|
|
|
|
|
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:41:18
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn do_vec(x: &Vec<i64>);
|
2017-09-10 17:32:24 +00:00
|
|
|
| ^^^^^^^^^ help: change this to: `&[i64]`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:54:14
|
2017-09-16 07:10:26 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn cloned(x: &Vec<u8>) -> Vec<u8> {
|
2017-09-16 07:10:26 +00:00
|
|
|
| ^^^^^^^^
|
2019-10-26 19:53:42 +00:00
|
|
|
|
|
2017-09-16 07:10:26 +00:00
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn cloned(x: &[u8]) -> Vec<u8> {
|
|
|
|
LL ~ let e = x.to_owned();
|
|
|
|
LL | let f = e.clone(); // OK
|
|
|
|
LL | let g = x;
|
|
|
|
LL ~ let h = g.to_owned();
|
|
|
|
LL | let i = (e).clone();
|
2022-06-16 14:00:32 +00:00
|
|
|
LL ~ x.to_owned()
|
|
|
|
|
|
2017-09-16 07:10:26 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&String` instead of `&str` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:63:18
|
2017-09-16 07:10:26 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn str_cloned(x: &String) -> String {
|
2017-09-16 07:10:26 +00:00
|
|
|
| ^^^^^^^
|
2019-10-26 19:53:42 +00:00
|
|
|
|
|
2017-09-16 07:10:26 +00:00
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn str_cloned(x: &str) -> String {
|
|
|
|
LL ~ let a = x.to_owned();
|
|
|
|
LL ~ let b = x.to_owned();
|
|
|
|
LL | let c = b.clone();
|
|
|
|
LL | let d = a.clone().clone().clone();
|
|
|
|
LL ~ x.to_owned()
|
2017-11-10 07:58:54 +00:00
|
|
|
|
|
2017-09-16 07:10:26 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:71:19
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
LL | fn path_cloned(x: &PathBuf) -> PathBuf {
|
|
|
|
| ^^^^^^^^
|
|
|
|
|
|
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn path_cloned(x: &Path) -> PathBuf {
|
|
|
|
LL ~ let a = x.to_path_buf();
|
|
|
|
LL ~ let b = x.to_path_buf();
|
|
|
|
LL | let c = b.clone();
|
|
|
|
LL | let d = a.clone().clone().clone();
|
|
|
|
LL ~ x.to_path_buf()
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&String` instead of `&str` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:79:44
|
2017-09-20 21:59:23 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn false_positive_capacity(x: &Vec<u8>, y: &String) {
|
2017-09-20 21:59:23 +00:00
|
|
|
| ^^^^^^^
|
2019-10-26 19:53:42 +00:00
|
|
|
|
|
2017-09-20 21:59:23 +00:00
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn false_positive_capacity(x: &Vec<u8>, y: &str) {
|
|
|
|
LL | let a = x.capacity();
|
|
|
|
LL ~ let b = y.to_owned();
|
|
|
|
LL ~ let c = y;
|
2017-09-20 21:59:23 +00:00
|
|
|
|
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: using a reference to `Cow` is not recommended
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:93:25
|
2018-04-05 15:59:35 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | fn test_cow_with_ref(c: &Cow<[i32]>) {}
|
2018-04-05 15:59:35 +00:00
|
|
|
| ^^^^^^^^^^^ help: change this to: `&[i32]`
|
|
|
|
|
2022-06-30 08:50:09 +00:00
|
|
|
error: writing `&String` instead of `&str` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:122:66
|
2022-06-30 08:50:09 +00:00
|
|
|
|
|
|
|
|
LL | fn some_allowed(#[allow(clippy::ptr_arg)] _v: &Vec<u32>, _s: &String) {}
|
|
|
|
| ^^^^^^^ help: change this to: `&str`
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:151:21
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
LL | fn foo_vec(vec: &Vec<u8>) {
|
|
|
|
| ^^^^^^^^
|
|
|
|
|
|
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn foo_vec(vec: &[u8]) {
|
|
|
|
LL ~ let _ = vec.to_owned().pop();
|
|
|
|
LL ~ let _ = vec.to_owned().clone();
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:156:23
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
LL | fn foo_path(path: &PathBuf) {
|
|
|
|
| ^^^^^^^^
|
|
|
|
|
|
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn foo_path(path: &Path) {
|
|
|
|
LL ~ let _ = path.to_path_buf().pop();
|
|
|
|
LL ~ let _ = path.to_path_buf().clone();
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:161:21
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
|
|
|
LL | fn foo_str(str: &PathBuf) {
|
|
|
|
| ^^^^^^^^
|
|
|
|
|
|
|
|
|
help: change this to
|
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL ~ fn foo_str(str: &Path) {
|
|
|
|
LL ~ let _ = str.to_path_buf().pop();
|
|
|
|
LL ~ let _ = str.to_path_buf().clone();
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
|
|
|
|
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:167:29
|
2021-01-02 15:29:43 +00:00
|
|
|
|
|
2022-01-27 14:12:45 +00:00
|
|
|
LL | fn mut_vec_slice_methods(v: &mut Vec<u32>) {
|
|
|
|
| ^^^^^^^^^^^^^ help: change this to: `&mut [u32]`
|
2021-01-02 15:29:43 +00:00
|
|
|
|
2022-10-23 13:18:45 +00:00
|
|
|
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:229:17
|
2022-10-23 13:18:45 +00:00
|
|
|
|
|
|
|
|
LL | fn dyn_trait(a: &mut Vec<u32>, b: &mut String, c: &mut PathBuf) {
|
|
|
|
| ^^^^^^^^^^^^^ help: change this to: `&mut [u32]`
|
|
|
|
|
|
|
|
error: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:229:35
|
2022-10-23 13:18:45 +00:00
|
|
|
|
|
|
|
|
LL | fn dyn_trait(a: &mut Vec<u32>, b: &mut String, c: &mut PathBuf) {
|
|
|
|
| ^^^^^^^^^^^ help: change this to: `&mut str`
|
|
|
|
|
|
|
|
error: writing `&mut PathBuf` instead of `&mut Path` involves a new object where a slice will do
|
2023-07-02 12:35:19 +00:00
|
|
|
--> $DIR/ptr_arg.rs:229:51
|
2022-10-23 13:18:45 +00:00
|
|
|
|
|
|
|
|
LL | fn dyn_trait(a: &mut Vec<u32>, b: &mut String, c: &mut PathBuf) {
|
|
|
|
| ^^^^^^^^^^^^ help: change this to: `&mut Path`
|
|
|
|
|
2023-07-02 12:35:19 +00:00
|
|
|
error: using a reference to `Cow` is not recommended
|
|
|
|
--> $DIR/ptr_arg.rs:252:39
|
|
|
|
|
|
|
|
|
LL | fn cow_elided_lifetime<'a>(input: &'a Cow<str>) -> &'a str {
|
|
|
|
| ^^^^^^^^^^^^ help: change this to: `&str`
|
|
|
|
|
|
|
|
error: using a reference to `Cow` is not recommended
|
|
|
|
--> $DIR/ptr_arg.rs:257:36
|
|
|
|
|
|
|
|
|
LL | fn cow_bad_ret_ty_1<'a>(input: &'a Cow<'a, str>) -> &'static str {
|
|
|
|
| ^^^^^^^^^^^^^^^^ help: change this to: `&str`
|
|
|
|
|
|
|
|
error: using a reference to `Cow` is not recommended
|
|
|
|
--> $DIR/ptr_arg.rs:260:40
|
|
|
|
|
|
|
|
|
LL | fn cow_bad_ret_ty_2<'a, 'b>(input: &'a Cow<'a, str>) -> &'b str {
|
|
|
|
| ^^^^^^^^^^^^^^^^ help: change this to: `&str`
|
|
|
|
|
|
|
|
error: aborting due to 23 previous errors
|
2018-01-16 16:06:27 +00:00
|
|
|
|