2016-05-06 14:07:47 +00:00
# rust-clippy
2017-08-06 11:10:21 +00:00
[![Build Status ](https://travis-ci.org/rust-lang-nursery/rust-clippy.svg?branch=master )](https://travis-ci.org/rust-lang-nursery/rust-clippy)
[![Windows build status ](https://ci.appveyor.com/api/projects/status/github/rust-lang-nursery/rust-clippy?svg=true )](https://ci.appveyor.com/project/rust-lang-nursery/rust-clippy)
2018-05-04 12:23:53 +00:00
[![Current Version ](https://meritbadge.herokuapp.com/clippy )](https://crates.io/crates/clippy)
2017-11-22 20:26:11 +00:00
[![License: MPL-2.0 ](https://img.shields.io/crates/l/clippy.svg )](#license)
2014-11-19 07:50:46 +00:00
2017-10-14 19:47:38 +00:00
A collection of lints to catch common mistakes and improve your [Rust ](https://github.com/rust-lang/rust ) code.
2014-11-19 19:19:03 +00:00
2018-05-04 13:54:56 +00:00
[There are 258 lints included in this crate! ](https://rust-lang-nursery.github.io/rust-clippy/master/index.html )
2017-09-01 18:29:36 +00:00
2018-03-29 11:04:52 +00:00
We have a bunch of lint categories to allow you to choose how much clippy is supposed to ~~annoy~~ help you:
* `clippy` (everything that has no false positives)
* `clippy_pedantic` (everything)
2018-04-10 11:50:44 +00:00
* `clippy_nursery` (new lints that aren't quite ready yet)
2018-03-29 11:04:52 +00:00
* `clippy_style` (code that should be written in a more idiomatic way)
2018-04-04 17:49:55 +00:00
* `clippy_complexity` (code that does something simple but in a complex way)
* `clippy_perf` (code that can be written in a faster way)
2018-04-29 23:20:39 +00:00
* `clippy_cargo` (checks against the cargo manifest)
2018-04-04 17:49:55 +00:00
* **`clippy_correctness`** (code that is just outright wrong or very very useless)
2018-03-29 11:04:52 +00:00
2017-09-01 18:29:36 +00:00
More to come, please [file an issue ](https://github.com/rust-lang-nursery/rust-clippy/issues ) if you have ideas!
2016-02-22 14:50:40 +00:00
Table of contents:
2016-03-10 20:42:24 +00:00
2016-05-06 14:07:47 +00:00
* [Usage instructions ](#usage )
* [Configuration ](#configuration )
* [License ](#license )
2016-09-15 15:19:30 +00:00
## Usage
2016-11-19 03:46:12 +00:00
Since this is a tool for helping the developer of a library or application
2016-11-20 03:16:36 +00:00
write better code, it is recommended not to include clippy as a hard dependency.
Options include using it as an optional dependency, as a cargo subcommand, or
as an included feature during build. All of these options are detailed below.
2016-11-19 03:46:12 +00:00
2016-09-15 15:19:30 +00:00
As a general rule clippy will only work with the *latest* Rust nightly for now.
2018-04-02 09:13:02 +00:00
To install Rust nightly, the recommended way is to use [rustup ](https://rustup.rs/ ):
```terminal
rustup install nightly
```
2017-12-27 16:06:40 +00:00
### As a cargo subcommand (`cargo clippy`)
One way to use clippy is by installing clippy through cargo as a cargo
subcommand.
```terminal
2018-01-12 10:33:13 +00:00
cargo +nightly install clippy
2017-12-27 16:06:40 +00:00
```
2018-01-12 10:33:13 +00:00
(The `+nightly` is not necessary if your default `rustup` install is nightly)
Now you can run clippy by invoking `cargo +nightly clippy` .
2017-12-27 16:06:40 +00:00
2018-04-02 09:13:02 +00:00
To update the subcommand together with the latest nightly use the [rust-update ](rust-update ) script or run:
```terminal
rustup update nightly
cargo +nightly install --force clippy
```
2017-12-27 16:06:40 +00:00
In case you are not using rustup, you need to set the environment flag
`SYSROOT` during installation so clippy knows where to find `librustc` and
similar crates.
```terminal
SYSROOT=/path/to/rustc/sysroot cargo install clippy
```
2016-09-15 15:19:30 +00:00
2018-02-08 11:37:56 +00:00
### Running clippy from the command line without installing it
2016-09-15 15:19:30 +00:00
2018-05-11 11:20:39 +00:00
To have cargo compile your crate with clippy without clippy installation
2016-09-15 15:19:30 +00:00
in your code, you can use:
```terminal
2018-02-08 11:37:56 +00:00
cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml
2016-09-15 15:19:30 +00:00
```
2017-08-06 11:10:21 +00:00
*[Note](https://github.com/rust-lang-nursery/rust-clippy/wiki#a-word-of-warning):*
2016-09-15 15:19:30 +00:00
Be sure that clippy was compiled with the same version of rustc that cargo invokes here!
## Configuration
2018-03-25 08:57:15 +00:00
Some lints can be configured in a TOML file named with `clippy.toml` or `.clippy.toml` . It contains basic `variable = value` mapping eg.
2016-09-15 15:19:30 +00:00
```toml
blacklisted-names = ["toto", "tata", "titi"]
cyclomatic-complexity-threshold = 30
```
2018-01-07 11:50:42 +00:00
See the [list of lints ](https://rust-lang-nursery.github.io/rust-clippy/master/index.html ) for more information about which lints can be configured and the
2016-09-15 15:19:30 +00:00
meaning of the variables.
2018-01-07 11:50:42 +00:00
To deactivate the “for further information visit *lint-link* ” message you can
2017-09-01 08:29:49 +00:00
define the `CLIPPY_DISABLE_DOCS_LINKS` environment variable.
2016-09-15 15:19:30 +00:00
### Allowing/denying lints
You can add options to `allow` /`warn`/`deny`:
* the whole set of `Warn` lints using the `clippy` lint group (`#![deny(clippy)]`)
* all lints using both the `clippy` and `clippy_pedantic` lint groups (`#![deny(clippy)]`,
`#![deny(clippy_pedantic)]` ). Note that `clippy_pedantic` contains some very aggressive
lints prone to false positives.
* only some lints (`#![deny(single_match, box_vec)]`, etc)
* `allow` /`warn`/`deny` can be limited to a single function or module using `#[allow(...)]` , etc
Note: `deny` produces errors instead of warnings.
2016-10-24 14:04:00 +00:00
For convenience, `cargo clippy` automatically defines a `cargo-clippy`
2018-04-02 09:13:02 +00:00
feature. This lets you set lint levels and compile with or without clippy
2016-10-24 14:04:00 +00:00
transparently:
```rust
#[cfg_attr(feature = "cargo-clippy", allow(needless_lifetimes))]
```
2017-10-11 18:50:58 +00:00
## Updating rustc
Sometimes, rustc moves forward without clippy catching up. Therefore updating
rustc may leave clippy a non-functional state until we fix the resulting
breakage.
You can use the [rust-update ](rust-update ) script to update rustc only if
clippy would also update correctly.
2016-05-06 14:07:47 +00:00
## License
Licensed under [MPL ](https://www.mozilla.org/MPL/2.0/ ).
If you're having issues with the license, let me know and I'll try to change it to something more permissive.