2018-07-28 15:34:52 +00:00
|
|
|
#![warn(clippy::unit_cmp)]
|
2022-05-21 11:24:00 +00:00
|
|
|
#![allow(
|
|
|
|
clippy::no_effect,
|
|
|
|
clippy::unnecessary_operation,
|
2023-07-02 12:35:19 +00:00
|
|
|
clippy::derive_partial_eq_without_eq,
|
|
|
|
clippy::needless_if
|
2022-05-21 11:24:00 +00:00
|
|
|
)]
|
2015-08-19 04:54:20 +00:00
|
|
|
|
2015-09-10 06:51:14 +00:00
|
|
|
#[derive(PartialEq)]
|
|
|
|
pub struct ContainsUnit(()); // should be fine
|
|
|
|
|
2015-08-19 04:54:20 +00:00
|
|
|
fn main() {
|
|
|
|
// this is fine
|
2018-12-09 22:26:16 +00:00
|
|
|
if true == false {}
|
2015-08-19 04:54:20 +00:00
|
|
|
|
|
|
|
// this warns
|
2018-12-09 22:26:16 +00:00
|
|
|
if {
|
2023-08-24 19:32:12 +00:00
|
|
|
//~^ ERROR: ==-comparison of unit values detected. This will always be true
|
|
|
|
//~| NOTE: `-D clippy::unit-cmp` implied by `-D warnings`
|
2018-12-09 22:26:16 +00:00
|
|
|
true;
|
|
|
|
} == {
|
|
|
|
false;
|
|
|
|
} {}
|
|
|
|
|
|
|
|
if {
|
2023-08-24 19:32:12 +00:00
|
|
|
//~^ ERROR: >-comparison of unit values detected. This will always be false
|
2018-12-09 22:26:16 +00:00
|
|
|
true;
|
|
|
|
} > {
|
|
|
|
false;
|
|
|
|
} {}
|
2019-10-02 20:48:19 +00:00
|
|
|
|
2019-10-03 12:38:04 +00:00
|
|
|
assert_eq!(
|
2023-08-24 19:32:12 +00:00
|
|
|
//~^ ERROR: `assert_eq` of unit values detected. This will always succeed
|
2019-10-03 12:38:04 +00:00
|
|
|
{
|
|
|
|
true;
|
|
|
|
},
|
|
|
|
{
|
|
|
|
false;
|
|
|
|
}
|
|
|
|
);
|
|
|
|
debug_assert_eq!(
|
2023-08-24 19:32:12 +00:00
|
|
|
//~^ ERROR: `debug_assert_eq` of unit values detected. This will always succeed
|
2019-10-03 12:38:04 +00:00
|
|
|
{
|
|
|
|
true;
|
|
|
|
},
|
|
|
|
{
|
|
|
|
false;
|
|
|
|
}
|
|
|
|
);
|
2019-10-02 20:48:19 +00:00
|
|
|
|
2019-10-03 12:38:04 +00:00
|
|
|
assert_ne!(
|
2023-08-24 19:32:12 +00:00
|
|
|
//~^ ERROR: `assert_ne` of unit values detected. This will always fail
|
2019-10-03 12:38:04 +00:00
|
|
|
{
|
|
|
|
true;
|
|
|
|
},
|
|
|
|
{
|
|
|
|
false;
|
|
|
|
}
|
|
|
|
);
|
|
|
|
debug_assert_ne!(
|
2023-08-24 19:32:12 +00:00
|
|
|
//~^ ERROR: `debug_assert_ne` of unit values detected. This will always fail
|
2019-10-03 12:38:04 +00:00
|
|
|
{
|
|
|
|
true;
|
|
|
|
},
|
|
|
|
{
|
|
|
|
false;
|
|
|
|
}
|
|
|
|
);
|
2015-08-19 04:54:20 +00:00
|
|
|
}
|