rust-clippy/tests/ui/or_then_unwrap.fixed

53 lines
1.4 KiB
Rust
Raw Normal View History

//@run-rustfix
2022-03-18 22:18:36 +00:00
#![warn(clippy::or_then_unwrap)]
#![allow(clippy::map_identity, clippy::let_unit_value)]
2022-03-18 22:18:36 +00:00
2022-03-27 12:41:09 +00:00
struct SomeStruct;
2022-03-18 22:18:36 +00:00
impl SomeStruct {
fn or(self, _: Option<Self>) -> Self {
self
}
fn unwrap(&self) {}
}
2022-03-27 12:41:09 +00:00
struct SomeOtherStruct;
2022-03-18 22:18:36 +00:00
impl SomeOtherStruct {
fn or(self) -> Self {
self
}
fn unwrap(&self) {}
}
fn main() {
let option: Option<&str> = None;
let _ = option.unwrap_or("fallback"); // should trigger lint
let result: Result<&str, &str> = Err("Error");
let _ = result.unwrap_or("fallback"); // should trigger lint
2022-03-19 17:17:43 +00:00
// as part of a method chain
let option: Option<&str> = None;
let _ = option.map(|v| v).unwrap_or("fallback").to_string().chars(); // should trigger lint
2022-03-18 22:18:36 +00:00
// Not Option/Result
let instance = SomeStruct {};
let _ = instance.or(Some(SomeStruct {})).unwrap(); // should not trigger lint
// or takes no argument
let instance = SomeOtherStruct {};
let _ = instance.or().unwrap(); // should not trigger lint and should not panic
// None in or
let option: Option<&str> = None;
let _ = option.or(None).unwrap(); // should not trigger lint
// Not Err in or
let result: Result<&str, &str> = Err("Error");
let _ = result.or::<&str>(Err("Other Error")).unwrap(); // should not trigger lint
// other function between
let option: Option<&str> = None;
let _ = option.or(Some("fallback")).map(|v| v).unwrap(); // should not trigger lint
}