rust-clippy/tests/ui/block_in_if_condition.stderr

53 lines
1.7 KiB
Text
Raw Normal View History

error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
2017-08-01 15:54:21 +00:00
--> $DIR/block_in_if_condition.rs:30:8
|
2017-02-08 13:58:07 +00:00
30 | if {
| ________^
31 | | let x = 3;
32 | | x == 3
33 | | } {
| |_____^
|
= note: `-D block-in-if-condition-stmt` implied by `-D warnings`
= help: try
2017-02-08 13:58:07 +00:00
let res = {
let x = 3;
x == 3
};
if res {
6
} ...
error: omit braces around single expression condition
2017-08-01 15:54:21 +00:00
--> $DIR/block_in_if_condition.rs:41:8
|
2017-02-08 13:58:07 +00:00
41 | if { true } {
| ^^^^^^^^
|
= note: `-D block-in-if-condition-expr` implied by `-D warnings`
= help: try
2017-02-08 13:58:07 +00:00
if true {
6
} ...
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
2017-08-01 15:54:21 +00:00
--> $DIR/block_in_if_condition.rs:58:49
|
58 | if v == 3 && sky == "blue" && predicate(|x| { let target = 3; x == target }, v) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
2017-08-01 15:54:21 +00:00
--> $DIR/block_in_if_condition.rs:61:22
|
61 | if predicate(|x| { let target = 3; x == target }, v) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: this boolean expression can be simplified
2017-08-01 15:54:21 +00:00
--> $DIR/block_in_if_condition.rs:67:8
|
67 | if true && x == 3 {
2017-07-21 08:40:23 +00:00
| ^^^^^^^^^^^^^^ help: try: `x == 3`
|
= note: `-D nonminimal-bool` implied by `-D warnings`